Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-29 Thread Jiri Bohac
On Wed, Nov 29, 2017 at 10:43:07AM +0800, Baoquan He wrote: > On 11/28/17 at 10:58pm, Jiri Bohac wrote: > > On Sun, Nov 12, 2017 at 04:04:26PM +0800, Baoquan He wrote: > > > Solution: > > > 1) Remove the code which support GART IOMMU when it's not enabled in > > > BIOS. This has been done in the ne

Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-28 Thread Baoquan He
On 11/28/17 at 10:58pm, Jiri Bohac wrote: > Hi Baoquan, > > On Sun, Nov 12, 2017 at 04:04:26PM +0800, Baoquan He wrote: > > Solution: > > 1) Remove the code which support GART IOMMU when it's not enabled in > > BIOS. This has been done in the new generation of hardware IOMMU like > > intel vt-d IO

Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-28 Thread Jiri Bohac
Hi Baoquan, On Sun, Nov 12, 2017 at 04:04:26PM +0800, Baoquan He wrote: > Solution: > 1) Remove the code which support GART IOMMU when it's not enabled in > BIOS. This has been done in the new generation of hardware IOMMU like > intel vt-d IOMMU and amd-Vi IOMMU. We should not make GART IOMMU be >

Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-12 Thread Baoquan He
On 11/12/17 at 04:04pm, Baoquan He wrote: > On 11/07/17 at 04:34pm, Jiri Bohac wrote: > > On Tue, Nov 07, 2017 at 02:42:12PM +0100, Jiri Bohac wrote: > > > On Tue, Nov 07, 2017 at 07:39:56PM +0800, Baoquan He wrote: > > > > don't worry about the user space kexec utility either. > > > > > > What's

Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-12 Thread Baoquan He
On 11/07/17 at 04:34pm, Jiri Bohac wrote: > On Tue, Nov 07, 2017 at 02:42:12PM +0100, Jiri Bohac wrote: > > On Tue, Nov 07, 2017 at 07:39:56PM +0800, Baoquan He wrote: > > > don't worry about the user space kexec utility either. > > > > What's the problem with the userspace kexec? The bug is in >

Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-07 Thread Jiri Bohac
On Tue, Nov 07, 2017 at 02:42:12PM +0100, Jiri Bohac wrote: > On Tue, Nov 07, 2017 at 07:39:56PM +0800, Baoquan He wrote: > > don't worry about the user space kexec utility either. > > What's the problem with the userspace kexec? The bug is in > reading /proc/vmcore by makedumpfile. kexec would o

Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-07 Thread Jiri Bohac
On Tue, Nov 07, 2017 at 07:39:56PM +0800, Baoquan He wrote: > I saw you defined the variable as xx_stolen_xx, does it mean that the > memory region where aperture located will be stolen from memory domain? > I am wondering if it will cause error when access this region from direct > mapping since a

Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-07 Thread Baoquan He
On 11/06/17 at 10:56am, Jiri Bohac wrote: > On Mon, Nov 06, 2017 at 05:27:29PM +0800, Baoquan He wrote: > > > 0010-c7e7 : System RAM > > > 0b00-0b792eb5 : Kernel code > > > 0b792eb6-0bd5d47f : Kernel data > > > 0c274000-0c3c8fff : Kernel bss > > > b700-c6ff : C

Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-06 Thread Jiri Bohac
On Mon, Nov 06, 2017 at 05:27:29PM +0800, Baoquan He wrote: > > 0010-c7e7 : System RAM > > 0b00-0b792eb5 : Kernel code > > 0b792eb6-0bd5d47f : Kernel data > > 0c274000-0c3c8fff : Kernel bss > > b700-c6ff : Crash kernel > > It's weird, gart aperture l

Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-06 Thread Baoquan He
Hi Jiri, Thanks for providing these information. On 11/06/17 at 10:01am, Jiri Bohac wrote: > Hi Baoquan, > > [0.00] memblock_reserve: > [0xb800-0xbbff] gart_iommu_hole_init+0x396/0x4b6 > [0.00] AGP: Mapping aperture over RAM [mem > 0xb800

Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-06 Thread Jiri Bohac
Hi Baoquan, On Mon, Nov 06, 2017 at 10:41:43AM +0800, Baoquan He wrote: > Is this reproduced on a machine with GART existing and passing test with > this patch applied? Do you have a /proc/iomem printing about the machine > you are testing on? I've seen this on at least three different machines.

Re: [PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-05 Thread Baoquan He
Hi Jiri, On 11/03/17 at 06:28pm, Jiri Bohac wrote: > On machines where the GART aperture is mapped over physical RAM > /proc/vmcore contains the remapped range and reading it may > cause hangs or reboots. This range needs to be excluded from /proc/vmcore. > > This has originally been implemented

[PATCH] x86/kexec: Exclude GART aperture from vmcore

2017-11-03 Thread Jiri Bohac
On machines where the GART aperture is mapped over physical RAM /proc/vmcore contains the remapped range and reading it may cause hangs or reboots. This range needs to be excluded from /proc/vmcore. This has originally been implemented by commit dd5f726076cc ("kexec: support for kexec on panic usi