Re: [PATCH] x86/intel_rdt: Implement "update" mode when writing schemata file

2017-03-31 Thread Shivappa Vikas
On Fri, 24 Mar 2017, Luck, Tony wrote: +++ b/arch/x86/kernel/cpu/intel_rdt_schemata.c @@ -56,7 +56,7 @@ static bool cbm_validate(unsigned long var, struct rdt_resource *r) * Read one cache bit mask (hex). Check that it is valid for the current * resource type. */ -static int parse_cbm(char

Re: [PATCH] x86/intel_rdt: Implement "update" mode when writing schemata file

2017-03-31 Thread Thomas Gleixner
On Fri, 31 Mar 2017, Shivappa Vikas wrote: > On Fri, 31 Mar 2017, Thomas Gleixner wrote: > > > On Fri, 24 Mar 2017, Luck, Tony wrote: > > > +Reading/writing the schemata file > > > +- > > > +Reading the schemata file will show the state of all resources > > > +on al

Re: [PATCH] x86/intel_rdt: Implement "update" mode when writing schemata file

2017-03-31 Thread Shivappa Vikas
On Fri, 31 Mar 2017, Thomas Gleixner wrote: On Fri, 24 Mar 2017, Luck, Tony wrote: +Reading/writing the schemata file +- +Reading the schemata file will show the state of all resources +on all domains. When writing you only need to specify those values +which y

Re: [PATCH] x86/intel_rdt: Implement "update" mode when writing schemata file

2017-03-31 Thread Thomas Gleixner
On Fri, 24 Mar 2017, Luck, Tony wrote: > +Reading/writing the schemata file > +- > +Reading the schemata file will show the state of all resources > +on all domains. When writing you only need to specify those values > +which you wish to change. E.g. > + > +# cat sc

Re: [PATCH] x86/intel_rdt: Implement "update" mode when writing schemata file

2017-03-30 Thread Shivappa Vikas
On Fri, 24 Mar 2017, Fenghua Yu wrote: On Fri, Mar 24, 2017 at 10:51:58AM -0700, Luck, Tony wrote: From: Tony Luck The schemata file can have multiple lines and it is cumbersome to update from shell scripts. "from shell scripts" makes people a bit confused. Not just shell scripts, C or Ja

Re: [PATCH] x86/intel_rdt: Implement "update" mode when writing schemata file

2017-03-24 Thread Fenghua Yu
On Fri, Mar 24, 2017 at 10:51:58AM -0700, Luck, Tony wrote: > From: Tony Luck > > The schemata file can have multiple lines and it is cumbersome to > update from shell scripts. "from shell scripts" makes people a bit confused. Not just shell scripts, C or Java code also can be cumbersome to upda

[PATCH] x86/intel_rdt: Implement "update" mode when writing schemata file

2017-03-24 Thread Luck, Tony
From: Tony Luck The schemata file can have multiple lines and it is cumbersome to update from shell scripts. Remove code that requires that the user provide values for every resource (in the right order). If the user provides values for just a few resources, update them and leave the rest uncha