Re: [PATCH] x86/hyper-v: Stop caring about EOI for direct stimers

2018-12-14 Thread Paolo Bonzini
On 05/12/18 16:36, Vitaly Kuznetsov wrote: > Turns out we over-engineered Direct Mode for stimers a bit: unlike > traditional stimers where we may want to try to re-inject the message upon > EOI, Direct Mode stimers just set the irq in APIC and kvm_apic_set_irq() > fails only when APIC is disabled

Re: [PATCH] x86/hyper-v: Stop caring about EOI for direct stimers

2018-12-12 Thread Vitaly Kuznetsov
Roman Kagan writes: > [ Sorry, missed this one ] > > On Wed, Dec 05, 2018 at 04:36:21PM +0100, Vitaly Kuznetsov wrote: >> Turns out we over-engineered Direct Mode for stimers a bit: unlike >> traditional stimers where we may want to try to re-inject the message upon >> EOI, Direct Mode stimers ju

Re: [PATCH] x86/hyper-v: Stop caring about EOI for direct stimers

2018-12-10 Thread Roman Kagan
[ Sorry, missed this one ] On Wed, Dec 05, 2018 at 04:36:21PM +0100, Vitaly Kuznetsov wrote: > Turns out we over-engineered Direct Mode for stimers a bit: unlike > traditional stimers where we may want to try to re-inject the message upon > EOI, Direct Mode stimers just set the irq in APIC and kvm

[PATCH] x86/hyper-v: Stop caring about EOI for direct stimers

2018-12-05 Thread Vitaly Kuznetsov
Turns out we over-engineered Direct Mode for stimers a bit: unlike traditional stimers where we may want to try to re-inject the message upon EOI, Direct Mode stimers just set the irq in APIC and kvm_apic_set_irq() fails only when APIC is disabled (see APIC_DM_FIXED case in __apic_accept_irq()). Re