Re: [PATCH] x86/fpu: Use fault_in_pages_writeable() for pre-faulting

2019-05-28 Thread Andrew Morton
On Sun, 26 May 2019 19:33:25 +0200 Sebastian Andrzej Siewior wrote: > From: Hugh Dickins > > Since commit > >d9c9ce34ed5c8 ("x86/fpu: Fault-in user stack if copy_fpstate_to_sigframe() > fails") Please add this as a Fixes: d9c9ce34ed5c8 ("x86/fpu: Fault-in user stack if copy_fpstate_to

My emacs problem -- was Re: [PATCH] x86/fpu: Use fault_in_pages_writeable() for pre-faulting

2019-05-28 Thread Pavel Machek
Hi! On Sun 2019-05-26 12:25:27, Hugh Dickins wrote: > On Sun, 26 May 2019, Sebastian Andrzej Siewior wrote: > > On 2019-05-26 19:33:25 [+0200], To Hugh Dickins wrote: > > From: Hugh Dickins > > … > > > Signed-off-by: Hugh Dickins > > > > Hugh, I took your patch, slapped a signed-off-by line. Pl

Re: [PATCH] x86/fpu: Use fault_in_pages_writeable() for pre-faulting

2019-05-26 Thread Hugh Dickins
On Sun, 26 May 2019, Sebastian Andrzej Siewior wrote: > On 2019-05-26 19:33:25 [+0200], To Hugh Dickins wrote: > From: Hugh Dickins > … > > Signed-off-by: Hugh Dickins > > Hugh, I took your patch, slapped a signed-off-by line. Please say that > you are fine with it (or object otherwise). I'm fi

Re: [PATCH] x86/fpu: Use fault_in_pages_writeable() for pre-faulting

2019-05-26 Thread Sebastian Andrzej Siewior
On 2019-05-26 19:33:25 [+0200], To Hugh Dickins wrote: > From: Hugh Dickins … > Signed-off-by: Hugh Dickins Hugh, I took your patch, slapped a signed-off-by line. Please say that you are fine with it (or object otherwise). Sebastian

[PATCH] x86/fpu: Use fault_in_pages_writeable() for pre-faulting

2019-05-26 Thread Sebastian Andrzej Siewior
From: Hugh Dickins Since commit d9c9ce34ed5c8 ("x86/fpu: Fault-in user stack if copy_fpstate_to_sigframe() fails") we use get_user_pages_unlocked() to pre-faulting user's memory if a write generates a page fault while the handler is disabled. This works in general and uncovered a bug as rep