Re: [PATCH] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Masahiro Yamada
On Wed, Dec 5, 2018 at 3:08 PM Zhenzhong Duan wrote: > > > On 2018/12/5 11:00, Masahiro Yamada wrote: > > It is wrong to add CONFIG option diagnostic to the Makefile parse > > stage. > > > > Once you are hit by the error about non-retpoline compiler, the > > compilation still breaks even after dis

Re: [PATCH] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Zhenzhong Duan
On 2018/12/5 11:00, Masahiro Yamada wrote: It is wrong to add CONFIG option diagnostic to the Makefile parse stage. Once you are hit by the error about non-retpoline compiler, the compilation still breaks even after disabling CONFIG_RETPOLINE. The easiest fix is to move this check to the "arc

Re: [PATCH] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Masahiro Yamada
On Wed, Dec 5, 2018 at 12:23 PM Zhenzhong Duan wrote: > > Hi Masahiro, > > > Thanks for fixing. > There is a question still confusing me. There are many CONFIG_* used in > arch/x86/Makefile. > Will they also be impacted or not? The top level Makefile (and arch/*/Makefile) is getting huge. Parsin

Re: [PATCH] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Zhenzhong Duan
Hi Masahiro, Thanks for fixing. There is a question still confusing me. There are many CONFIG_* used in arch/x86/Makefile. Will they also be impacted or not? # grep CONFIG_ arch/x86/Makefile ifeq ($(CONFIG_X86_32),y)     cflags-$(CONFIG_MK8) += $(call cc-option,-march=k8)     cflags-$

[PATCH] x86/build: fix compiler support check for CONFIG_RETPOLINE

2018-12-04 Thread Masahiro Yamada
It is wrong to add CONFIG option diagnostic to the Makefile parse stage. Once you are hit by the error about non-retpoline compiler, the compilation still breaks even after disabling CONFIG_RETPOLINE. The easiest fix is to move this check to the "archprepare" like commit 829fe4aa9ac1 ("x86: Allow