Re: [PATCH] x86/boot: clean up headers

2019-03-01 Thread Stephen Rothwell
Hi Nick, On Sat, 2 Mar 2019 13:27:50 +1100 Stephen Rothwell wrote: > > On Fri, 1 Mar 2019 16:07:14 -0800 Nick Desaulniers > wrote: > > > > It turns out that arch/x86/boot/string.c doesn't actually need > > linux/kernel.h, simply linux/limits.h and linux/compiler.h. Include them, > > and sort

Re: [PATCH] x86/boot: clean up headers

2019-03-01 Thread Stephen Rothwell
Hi Nick, On Fri, 1 Mar 2019 16:07:14 -0800 Nick Desaulniers wrote: > > It turns out that arch/x86/boot/string.c doesn't actually need > linux/kernel.h, simply linux/limits.h and linux/compiler.h. Include them, > and sort the headers alphabetically. One small nit: please do not do the sort in t

Re: [PATCH] x86/boot: clean up headers

2019-03-01 Thread Nathan Chancellor
On Fri, Mar 01, 2019 at 04:07:14PM -0800, Nick Desaulniers wrote: > The inclusion of was causing issue as the definition of > __arch_hweight64 from arch/x86/include/asm/arch_hweight.h eventually gets > included. The definition is problematic when compiled with -m16 (all code > in arch/x86/boot/ is

[PATCH] x86/boot: clean up headers

2019-03-01 Thread Nick Desaulniers
The inclusion of was causing issue as the definition of __arch_hweight64 from arch/x86/include/asm/arch_hweight.h eventually gets included. The definition is problematic when compiled with -m16 (all code in arch/x86/boot/ is) as the "D" inline assembly constraint is rejected by both compilers when