Re: [PATCH] x86/boot: Rename overlapping memcpy() to memmove()

2016-04-25 Thread Ingo Molnar
* Kees Cook wrote: > On Sat, Apr 23, 2016 at 4:08 AM, Ingo Molnar wrote: > > > > * Kees Cook wrote: > > > >> --- a/arch/x86/boot/compressed/string.c > >> +++ b/arch/x86/boot/compressed/string.c > >> @@ -1,7 +1,13 @@ > >> +/* > >> + * This provides an optimized implementation of memcpy, and a s

Re: [PATCH] x86/boot: Rename overlapping memcpy() to memmove()

2016-04-23 Thread Kees Cook
On Sat, Apr 23, 2016 at 4:08 AM, Ingo Molnar wrote: > > * Kees Cook wrote: > >> --- a/arch/x86/boot/compressed/string.c >> +++ b/arch/x86/boot/compressed/string.c >> @@ -1,7 +1,13 @@ >> +/* >> + * This provides an optimized implementation of memcpy, and a simplified >> + * implementation of memse

Re: [PATCH] x86/boot: Rename overlapping memcpy() to memmove()

2016-04-23 Thread Ingo Molnar
* Kees Cook wrote: > --- a/arch/x86/boot/compressed/string.c > +++ b/arch/x86/boot/compressed/string.c > @@ -1,7 +1,13 @@ > +/* > + * This provides an optimized implementation of memcpy, and a simplified > + * implementation of memset and memmove, to avoid problems with the > + * built-in implem

[PATCH] x86/boot: Rename overlapping memcpy() to memmove()

2016-04-22 Thread Kees Cook
Instead of having non-standard memcpy() behavior, explicitly call the new function memmove(), make it available to the decompressors, and switch the two overlap cases (screen scrolling and ELF parsing) to use memmove(). Additionally documents the purpose of compressed/string.c. Suggested-by: Lasse