Re: [PATCH] x86/alternatives: free smp_alt_modules when enable smp

2017-10-27 Thread Borislav Petkov
On Fri, Oct 27, 2017 at 04:11:17PM +0800, zhouchengming wrote: > So why not take the quick way like we do in > alternatives_smp_module_add() ? Because 1. there's no real problem with the current state 2. the current way is cleaner as it keeps that code away in module_arch_cleanup(). -- Regard

Re: [PATCH] x86/alternatives: free smp_alt_modules when enable smp

2017-10-27 Thread zhouchengming
On 2017/10/27 15:49, Borislav Petkov wrote: On Fri, Oct 27, 2017 at 03:18:12PM +0800, Zhou Chengming wrote: In the current code, we don't free smp_alt_modules when enable smp, so have to wait module unload to call alternatives_smp_module_del() to free its smp_alt_module. This strategy has shortc

Re: [PATCH] x86/alternatives: free smp_alt_modules when enable smp

2017-10-27 Thread Borislav Petkov
On Fri, Oct 27, 2017 at 03:18:12PM +0800, Zhou Chengming wrote: > In the current code, we don't free smp_alt_modules when enable smp, > so have to wait module unload to call alternatives_smp_module_del() > to free its smp_alt_module. This strategy has shortcomings. I love it when the commit messag

[PATCH] x86/alternatives: free smp_alt_modules when enable smp

2017-10-27 Thread Zhou Chengming
In the current code, we don't free smp_alt_modules when enable smp, so have to wait module unload to call alternatives_smp_module_del() to free its smp_alt_module. This strategy has shortcomings. We can make sure smp_alt_modules will be useless after enable smp, so free it all. And alternatives_smp