Re: [PATCH] x86,cpu-hotplug: clear llc_shared_mask at CPU hotplug

2014-07-08 Thread Yasuaki Ishimatsu
Hi Borislav, Sorry for late reply and thank you for your explanation. I'm implementing your suggestion. After finishing test, I'll post a patch again. So when I post a patch, please review it. Thanks, Yasuaki Ishimatsu (2014/07/04 19:59), Borislav Petkov wrote: On Fri, Jul 04, 2014 at 09:14:57

Re: [PATCH] x86,cpu-hotplug: clear llc_shared_mask at CPU hotplug

2014-07-04 Thread Borislav Petkov
On Fri, Jul 04, 2014 at 09:14:57AM +0900, Yasuaki Ishimatsu wrote: > If so, why following maps are cleared by CPU offline? > - cpu_sigling_map > - cpu_core_map I'll let you figure that out on your own by doing some quality code staring. Hint: search for usages outside of the CPU hotplug path.

Re: [PATCH] x86,cpu-hotplug: clear llc_shared_mask at CPU hotplug

2014-07-03 Thread Yasuaki Ishimatsu
(2014/07/03 18:51), Borislav Petkov wrote: On Thu, Jul 03, 2014 at 01:52:52PM +0900, Yasuaki Ishimatsu wrote: I think that the reason to apply CPU number to ACPI ID is that CPU is used for the application without considering physical CPU. So even if CPU number is changed, it is no matter. I do

Re: [PATCH] x86,cpu-hotplug: clear llc_shared_mask at CPU hotplug

2014-07-03 Thread Borislav Petkov
On Thu, Jul 03, 2014 at 01:52:52PM +0900, Yasuaki Ishimatsu wrote: > I think that the reason to apply CPU number to ACPI ID is that CPU is > used for the application without considering physical CPU. So even if > CPU number is changed, it is no matter. I don't think I understand what you're saying

Re: [PATCH] x86,cpu-hotplug: clear llc_shared_mask at CPU hotplug

2014-07-02 Thread Yasuaki Ishimatsu
(2014/07/02 20:32), Borislav Petkov wrote: On Wed, Jul 02, 2014 at 03:41:21PM +0900, Yasuaki Ishimatsu wrote: llc_shared_mask is not cleared even if cpu is offline or hot removed. So when hot-plugging CPU, the mask has wrong value. The mask is used by CSF schduler. So it breaks CFS scheduler. H

Re: [PATCH] x86,cpu-hotplug: clear llc_shared_mask at CPU hotplug

2014-07-02 Thread Mike Galbraith
(CC Peter) On Wed, 2014-07-02 at 15:41 +0900, Yasuaki Ishimatsu wrote: > llc_shared_mask is not cleared even if cpu is offline or hot removed. > So when hot-plugging CPU, the mask has wrong value. The mask is used > by CSF schduler. So it breaks CFS scheduler. > > Here is a example on my system.

Re: [PATCH] x86,cpu-hotplug: clear llc_shared_mask at CPU hotplug

2014-07-02 Thread Borislav Petkov
On Wed, Jul 02, 2014 at 03:41:21PM +0900, Yasuaki Ishimatsu wrote: > llc_shared_mask is not cleared even if cpu is offline or hot removed. > So when hot-plugging CPU, the mask has wrong value. The mask is used > by CSF schduler. So it breaks CFS scheduler. > > Here is a example on my system. > My

[PATCH] x86,cpu-hotplug: clear llc_shared_mask at CPU hotplug

2014-07-01 Thread Yasuaki Ishimatsu
llc_shared_mask is not cleared even if cpu is offline or hot removed. So when hot-plugging CPU, the mask has wrong value. The mask is used by CSF schduler. So it breaks CFS scheduler. Here is a example on my system. My system has 4 sockets and each socket has 15 cores and HT is enabled. In this ca