Re: [PATCH] x86,cpu-hotplug: assign same CPU number to readded CPU

2014-07-14 Thread Yasuaki Ishimatsu
Hi Borislav, (2014/07/11 19:59), Borislav Petkov wrote: On Fri, Jul 11, 2014 at 09:48:27AM +0900, Yasuaki Ishimatsu wrote: +static int get_cpuid(int apicid) Btw this "cpuid" is misleading. Call it "cpu_num" or so. O.K. I'll update it. +{ + int cpuid; + + cpuid = apicid_to_cp

Re: [PATCH] x86,cpu-hotplug: assign same CPU number to readded CPU

2014-07-11 Thread Borislav Petkov
On Fri, Jul 11, 2014 at 09:48:27AM +0900, Yasuaki Ishimatsu wrote: > >>+static int get_cpuid(int apicid) Btw this "cpuid" is misleading. Call it "cpu_num" or so. > >>+{ > >>+ int cpuid; > >>+ > >>+ cpuid = apicid_to_cpuid[apicid]; > >>+ if (cpuid < 0) > >>+ cpuid = cpumask_next_ze

Re: [PATCH] x86,cpu-hotplug: assign same CPU number to readded CPU

2014-07-10 Thread Yasuaki Ishimatsu
(2014/07/10 18:26), Igor Mammedov wrote: On Thu, 10 Jul 2014 17:41:50 +0900 Yasuaki Ishimatsu wrote: llc_shared_map is not cleared even if CPU is offline or hot removed. So when hot-plugging CPU and assigning new CPU number to hot-added CPU, the mask has wrong value. The mask is used by CSF sc

Re: [PATCH] x86,cpu-hotplug: assign same CPU number to readded CPU

2014-07-10 Thread Igor Mammedov
On Thu, 10 Jul 2014 17:41:50 +0900 Yasuaki Ishimatsu wrote: > llc_shared_map is not cleared even if CPU is offline or hot removed. > So when hot-plugging CPU and assigning new CPU number to hot-added CPU, > the mask has wrong value. The mask is used by CSF schduler to create > sched_domain. So it

[PATCH] x86,cpu-hotplug: assign same CPU number to readded CPU

2014-07-10 Thread Yasuaki Ishimatsu
llc_shared_map is not cleared even if CPU is offline or hot removed. So when hot-plugging CPU and assigning new CPU number to hot-added CPU, the mask has wrong value. The mask is used by CSF schduler to create sched_domain. So it breaks CFS scheduler. Here is a example on my system. My system has