Re: [PATCH] x86, traps: install gates using IST after cpu_init().

2015-02-27 Thread Andy Lutomirski
On Thu, Feb 26, 2015 at 8:34 PM, Wang Nan wrote: > On 2015/2/26 23:14, Andy Lutomirski wrote: >> On Wed, Feb 25, 2015 at 10:15 PM, Wang Nan wrote: >>> X86_TRAP_NMI, X86_TRAP_DF and X86_TRAP_MC use their own stack. Those >>> stacks are invalid until cpu_init() installs TSS. >>> >>> This patch move

Re: [PATCH] x86, traps: install gates using IST after cpu_init().

2015-02-26 Thread Wang Nan
On 2015/2/26 23:14, Andy Lutomirski wrote: > On Wed, Feb 25, 2015 at 10:15 PM, Wang Nan wrote: >> X86_TRAP_NMI, X86_TRAP_DF and X86_TRAP_MC use their own stack. Those >> stacks are invalid until cpu_init() installs TSS. >> >> This patch moves setting of the 3 gates after cpu_init(). >> >> Signed-o

Re: [PATCH] x86, traps: install gates using IST after cpu_init().

2015-02-26 Thread Andy Lutomirski
On Wed, Feb 25, 2015 at 10:15 PM, Wang Nan wrote: > X86_TRAP_NMI, X86_TRAP_DF and X86_TRAP_MC use their own stack. Those > stacks are invalid until cpu_init() installs TSS. > > This patch moves setting of the 3 gates after cpu_init(). > > Signed-off-by: Wang Nan > --- > > If I understand correctl

[PATCH] x86, traps: install gates using IST after cpu_init().

2015-02-25 Thread Wang Nan
X86_TRAP_NMI, X86_TRAP_DF and X86_TRAP_MC use their own stack. Those stacks are invalid until cpu_init() installs TSS. This patch moves setting of the 3 gates after cpu_init(). Signed-off-by: Wang Nan --- If I understand correctly, logically speaking the original code is incorrect. However, th