[PATCH] x86, mm: Add comments for step_size

2013-09-06 Thread Yinghai Lu
Current code use MACRO to have shift to set to 5, but there is not explanation about selection. Add comment about why we are using 5. Also add explanation that we don't need to worry about overflow on 32bit. -v3: According to Ingo, update changelog and comments. Signed-off-by: Yinghai Lu ---

Re: [PATCH] x86, mm: Add comments for step_size shift

2013-08-20 Thread Yinghai Lu
On Tue, Aug 20, 2013 at 1:18 AM, Ingo Molnar wrote: > > * Yinghai Lu wrote: > >> As request by hpa, add comments for why we choose 5 for >> step size shift. >> >> Signed-off-by: Yinghai Lu >> Reviewed-by: Tang Chen >> Tested-by: Tang Chen >> >> --- >> arch/x86/mm/init.c | 21 +++

Re: [PATCH] x86, mm: Add comments for step_size shift

2013-08-20 Thread Ingo Molnar
* Yinghai Lu wrote: > As request by hpa, add comments for why we choose 5 for > step size shift. > > Signed-off-by: Yinghai Lu > Reviewed-by: Tang Chen > Tested-by: Tang Chen > > --- > arch/x86/mm/init.c | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > >

[PATCH] x86, mm: Add comments for step_size shift

2013-08-14 Thread Yinghai Lu
As request by hpa, add comments for why we choose 5 for step size shift. Signed-off-by: Yinghai Lu Reviewed-by: Tang Chen Tested-by: Tang Chen --- arch/x86/mm/init.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) Index: linux-2.6/arch/x86/mm/init.c ===