Re: [PATCH] workqueue: fix rebind bound workers warning

2016-05-11 Thread Wanpeng Li
2016-05-11 18:03 GMT+08:00 Thomas Gleixner : > On Wed, 11 May 2016, Wanpeng Li wrote: >> Do you think the current version patch is the right fix/workaround for >> the existing mess? > > You might need something stateful related to the hotplug crap, as that > DOWN_FAILED/ONLINE case does a lot of st

Re: [PATCH] workqueue: fix rebind bound workers warning

2016-05-11 Thread Thomas Gleixner
On Wed, 11 May 2016, Wanpeng Li wrote: > Do you think the current version patch is the right fix/workaround for > the existing mess? You might need something stateful related to the hotplug crap, as that DOWN_FAILED/ONLINE case does a lot of stuff. Though I leave it to Tejun to decided whether yo

Re: [PATCH] workqueue: fix rebind bound workers warning

2016-05-11 Thread Wanpeng Li
2016-05-11 15:34 GMT+08:00 Thomas Gleixner : > On Wed, 11 May 2016, Wanpeng Li wrote: >> Hi Tejun, >> 2016-05-10 5:50 GMT+08:00 Wanpeng Li : >> > Cc Thomas, the new state machine author, >> > 2016-05-10 1:00 GMT+08:00 Tejun Heo : >> >> Hello, >> >> >> >> On Thu, May 05, 2016 at 09:41:31AM +0800, Wa

Re: [PATCH] workqueue: fix rebind bound workers warning

2016-05-11 Thread Thomas Gleixner
On Wed, 11 May 2016, Wanpeng Li wrote: > Hi Tejun, > 2016-05-10 5:50 GMT+08:00 Wanpeng Li : > > Cc Thomas, the new state machine author, > > 2016-05-10 1:00 GMT+08:00 Tejun Heo : > >> Hello, > >> > >> On Thu, May 05, 2016 at 09:41:31AM +0800, Wanpeng Li wrote: > >>> The boot CPU handles housekeepin

Re: [PATCH] workqueue: fix rebind bound workers warning

2016-05-10 Thread Wanpeng Li
Hi Tejun, 2016-05-10 5:50 GMT+08:00 Wanpeng Li : > Cc Thomas, the new state machine author, > 2016-05-10 1:00 GMT+08:00 Tejun Heo : >> Hello, >> >> On Thu, May 05, 2016 at 09:41:31AM +0800, Wanpeng Li wrote: >>> The boot CPU handles housekeeping duty(unbound timers, workqueues, >>> timekeeping, ...

Re: [PATCH] workqueue: fix rebind bound workers warning

2016-05-09 Thread Wanpeng Li
Cc Peterz, Frederic, 2016-05-10 5:50 GMT+08:00 Wanpeng Li : > Cc Thomas, the new state machine author, > 2016-05-10 1:00 GMT+08:00 Tejun Heo : >> Hello, >> >> On Thu, May 05, 2016 at 09:41:31AM +0800, Wanpeng Li wrote: >>> The boot CPU handles housekeeping duty(unbound timers, workqueues, >>> timek

Re: [PATCH] workqueue: fix rebind bound workers warning

2016-05-09 Thread Wanpeng Li
Cc Thomas, the new state machine author, 2016-05-10 1:00 GMT+08:00 Tejun Heo : > Hello, > > On Thu, May 05, 2016 at 09:41:31AM +0800, Wanpeng Li wrote: >> The boot CPU handles housekeeping duty(unbound timers, workqueues, >> timekeeping, ...) on behalf of full dynticks CPUs. It must remain >> onlin

Re: [PATCH] workqueue: fix rebind bound workers warning

2016-05-09 Thread Tejun Heo
Hello, On Thu, May 05, 2016 at 09:41:31AM +0800, Wanpeng Li wrote: > The boot CPU handles housekeeping duty(unbound timers, workqueues, > timekeeping, ...) on behalf of full dynticks CPUs. It must remain > online when nohz full is enabled. There is a priority set to every > notifier_blocks: > >

Re: [PATCH] workqueue: fix rebind bound workers warning

2016-05-09 Thread Wanpeng Li
Sorry to quick ping you Tejun, just hope it can catch the upcoming merge window. :-) 2016-05-05 9:41 GMT+08:00 Wanpeng Li : > From: Wanpeng Li > > [ cut here ] > WARNING: CPU: 0 PID: 16 at kernel/workqueue.c:4559 rebind_workers+0x1c0/0x1d0 > Modules linked in: > CPU: 0 PID:

[PATCH] workqueue: fix rebind bound workers warning

2016-05-04 Thread Wanpeng Li
From: Wanpeng Li [ cut here ] WARNING: CPU: 0 PID: 16 at kernel/workqueue.c:4559 rebind_workers+0x1c0/0x1d0 Modules linked in: CPU: 0 PID: 16 Comm: cpuhp/0 Not tainted 4.6.0-rc4+ #31 Hardware name: IBM IBM System x3550 M4 Server -[7914IUW]-/00Y8603, BIOS -[D7E128FUS-1.40]