Re: [PATCH] watchdog: aspeed: fix integer overflow in set_timeout handler

2021-04-15 Thread Guenter Roeck
On Thu, Apr 15, 2021 at 06:04:45PM -0700, Tao Ren wrote: > On Thu, Apr 15, 2021 at 05:50:32PM -0700, Guenter Roeck wrote: > > On 4/15/21 5:12 PM, rentao.b...@gmail.com wrote: > > > From: Tao Ren > > > > > > Fix the time comparison (timeout vs. max_hw_heartbeat_ms) in set_timeout > > > handler to

Re: [PATCH] watchdog: aspeed: fix integer overflow in set_timeout handler

2021-04-15 Thread Tao Ren
On Thu, Apr 15, 2021 at 05:50:32PM -0700, Guenter Roeck wrote: > On 4/15/21 5:12 PM, rentao.b...@gmail.com wrote: > > From: Tao Ren > > > > Fix the time comparison (timeout vs. max_hw_heartbeat_ms) in set_timeout > > handler to avoid potential integer overflow when the supplied timeout is > > gre

Re: [PATCH] watchdog: aspeed: fix integer overflow in set_timeout handler

2021-04-15 Thread Guenter Roeck
On 4/15/21 5:12 PM, rentao.b...@gmail.com wrote: > From: Tao Ren > > Fix the time comparison (timeout vs. max_hw_heartbeat_ms) in set_timeout > handler to avoid potential integer overflow when the supplied timeout is > greater than aspeed's maximum allowed timeout (4294 seconds). > > Fixes: efa8

Re: [PATCH] watchdog: aspeed: fix integer overflow in set_timeout handler

2021-04-15 Thread Joel Stanley
On Fri, 16 Apr 2021 at 00:12, wrote: > > From: Tao Ren > > Fix the time comparison (timeout vs. max_hw_heartbeat_ms) in set_timeout > handler to avoid potential integer overflow when the supplied timeout is > greater than aspeed's maximum allowed timeout (4294 seconds). > > Fixes: efa859f7d786 ("

[PATCH] watchdog: aspeed: fix integer overflow in set_timeout handler

2021-04-15 Thread rentao . bupt
From: Tao Ren Fix the time comparison (timeout vs. max_hw_heartbeat_ms) in set_timeout handler to avoid potential integer overflow when the supplied timeout is greater than aspeed's maximum allowed timeout (4294 seconds). Fixes: efa859f7d786 ("watchdog: Add Aspeed watchdog driver") Reported-by: