RE: [PATCH] wan: time_before()

2014-05-28 Thread Kevin Curtis
...@vger.kernel.org Subject: Re: [PATCH] wan: time_before() From: Joe Perches Date: Sun, 25 May 2014 10:58:52 -0700 > On Sun, 2014-05-25 at 19:32 +0200, Manuel Schölling wrote: >> To be future-proof and for better readability the time comparisons >> are modified to use time_befo

Re: [PATCH] wan: time_before()

2014-05-25 Thread David Miller
From: Joe Perches Date: Sun, 25 May 2014 10:58:52 -0700 > On Sun, 2014-05-25 at 19:32 +0200, Manuel Schölling wrote: >> To be future-proof and for better readability the time comparisons are >> modified to use time_before() instead of plain, error-prone math. > > Sensible change, but it seems th

Re: [PATCH] wan: time_before()

2014-05-25 Thread Joe Perches
On Sun, 2014-05-25 at 19:32 +0200, Manuel Schölling wrote: > To be future-proof and for better readability the time comparisons are > modified to use time_before() instead of plain, error-prone math. Sensible change, but it seems these should be udelay(some_constant) instead of a a rather variable

[PATCH] wan: time_before()

2014-05-25 Thread Manuel Schölling
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling --- drivers/net/wan/farsync.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wan/farsyn