Re: [PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-07-01 Thread Neil Horman
On Sat, Jun 30, 2018 at 10:15:07PM +0300, Dan Carpenter wrote: > Hi Neil, > > I love your patch! Perhaps something to improve: > > url: > https://github.com/0day-ci/linux/commits/Neil-Horman/vmw_pvrdma-Release-netdev-when-vmxnet3-module-is-removed/20180628-232414 > > smatch warnings: > drive

Re: [PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-06-30 Thread Dan Carpenter
Hi Neil, I love your patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Neil-Horman/vmw_pvrdma-Release-netdev-when-vmxnet3-module-is-removed/20180628-232414 smatch warnings: drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c:987 pvrdma_pci_probe() warn: variable

Re: [PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-06-29 Thread Neil Horman
On Thu, Jun 28, 2018 at 09:15:46PM +, Adit Ranadive wrote: > On 6/28/18, 1:37 PM, "Jason Gunthorpe" wrote: > > On Thu, Jun 28, 2018 at 03:45:26PM -0400, Neil Horman wrote: > > > On Thu, Jun 28, 2018 at 12:59:46PM -0600, Jason Gunthorpe wrote: > > > > On Thu, Jun 28, 2018 at 09:59:38AM -0400, N

Re: [PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-06-29 Thread Neil Horman
On Thu, Jun 28, 2018 at 02:37:09PM -0600, Jason Gunthorpe wrote: > On Thu, Jun 28, 2018 at 03:45:26PM -0400, Neil Horman wrote: > > On Thu, Jun 28, 2018 at 12:59:46PM -0600, Jason Gunthorpe wrote: > > > On Thu, Jun 28, 2018 at 09:59:38AM -0400, Neil Horman wrote: > > > > On repeated module load/unl

Re: [PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-06-28 Thread Adit Ranadive
On 6/28/18, 1:37 PM, "Jason Gunthorpe" wrote: > On Thu, Jun 28, 2018 at 03:45:26PM -0400, Neil Horman wrote: > > On Thu, Jun 28, 2018 at 12:59:46PM -0600, Jason Gunthorpe wrote: > > > On Thu, Jun 28, 2018 at 09:59:38AM -0400, Neil Horman wrote: > > > > On repeated module load/unload cycles, its po

Re: [PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-06-28 Thread Jason Gunthorpe
On Thu, Jun 28, 2018 at 03:45:26PM -0400, Neil Horman wrote: > On Thu, Jun 28, 2018 at 12:59:46PM -0600, Jason Gunthorpe wrote: > > On Thu, Jun 28, 2018 at 09:59:38AM -0400, Neil Horman wrote: > > > On repeated module load/unload cycles, its possible for the pvrmda > > > driver to encounter this cr

Re: [PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-06-28 Thread Neil Horman
On Thu, Jun 28, 2018 at 12:59:46PM -0600, Jason Gunthorpe wrote: > On Thu, Jun 28, 2018 at 09:59:38AM -0400, Neil Horman wrote: > > On repeated module load/unload cycles, its possible for the pvrmda > > driver to encounter this crash: > > > > ... > > 297.032448] RIP: 0010:[] [] > > netdev_walk_a

Re: [PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-06-28 Thread Jason Gunthorpe
On Thu, Jun 28, 2018 at 09:59:38AM -0400, Neil Horman wrote: > On repeated module load/unload cycles, its possible for the pvrmda > driver to encounter this crash: > > ... > 297.032448] RIP: 0010:[] [] > netdev_walk_all_upper_dev_rcu+0x50/0xb0 > [ 297.034078] RSP: 0018:95087780bd08 EFLAGS:

[PATCH] vmw_pvrdma: Release netdev when vmxnet3 module is removed

2018-06-28 Thread Neil Horman
On repeated module load/unload cycles, its possible for the pvrmda driver to encounter this crash: ... 297.032448] RIP: 0010:[] [] netdev_walk_all_upper_dev_rcu+0x50/0xb0 [ 297.034078] RSP: 0018:95087780bd08 EFLAGS: 00010286 [ 297.034986] RAX: RBX: RCX: f