Re: [PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header update

2014-02-03 Thread Vivek Goyal
On Mon, Feb 03, 2014 at 04:57:56PM +, Pearson, Greg wrote: [..] > > So I will not be too worried about skipping seemingly corrupted ELf > > notes. I think giving a warning makes sense though. Is somebody > > overwriting the memory area in kenrel reserved for per cpu PT_NOTE. > > I haven't fig

Re: [PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header update

2014-02-03 Thread Pearson, Greg
On 02/03/2014 08:47 AM, Vivek Goyal wrote: > On Sun, Feb 02, 2014 at 02:25:25PM -0800, Eric W. Biederman wrote: >> Andrew Morton writes: >> >>> On Sat, 1 Feb 2014 01:07:29 + "Pearson, Greg" >>> wrote: >>> As far as I know the only consequence of dropping a PT_NOTE entry is that it

Re: [PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header update

2014-02-03 Thread Vivek Goyal
On Sun, Feb 02, 2014 at 02:25:25PM -0800, Eric W. Biederman wrote: > Andrew Morton writes: > > > On Sat, 1 Feb 2014 01:07:29 + "Pearson, Greg" > > wrote: > > > >> As far as I know the only consequence of dropping a PT_NOTE entry is > >> that it would not be available in the crash dump for

Re: [PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header update

2014-02-02 Thread Eric W. Biederman
Andrew Morton writes: > On Sat, 1 Feb 2014 01:07:29 + "Pearson, Greg" wrote: > >> As far as I know the only consequence of dropping a PT_NOTE entry is >> that it would not be available in the crash dump for use in debugging. >> I'm not sure how important this data might be for triage. I'm

Re: [PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header update

2014-01-31 Thread Andrew Morton
On Sat, 1 Feb 2014 01:07:29 + "Pearson, Greg" wrote: > As far as I know the only consequence of dropping a PT_NOTE entry is > that it would not be available in the crash dump for use in debugging. > I'm not sure how important this data might be for triage. I'm guessing > that in cases wher

Re: [PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header update

2014-01-31 Thread Pearson, Greg
On 01/31/2014 04:16 PM, Andrew Morton wrote: > On Fri, 31 Jan 2014 16:06:06 -0700 Greg Pearson wrote: > >> Currently, update_note_header_size_elf64() and >> update_note_header_size_elf32() will add the size >> of a PT_NOTE entry to real_sz even if that causes real_sz >> to exceeds max_sz. This pat

[PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header update

2014-01-31 Thread Greg Pearson
Currently, update_note_header_size_elf64() and update_note_header_size_elf32() will add the size of a PT_NOTE entry to real_sz even if that causes real_sz to exceeds max_sz. This patch corrects the while loop logic in those routines to ensure that does not happen. One possible negative side effect

Re: [PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header update

2014-01-31 Thread Andrew Morton
On Fri, 31 Jan 2014 16:06:06 -0700 Greg Pearson wrote: > Currently, update_note_header_size_elf64() and > update_note_header_size_elf32() will add the size > of a PT_NOTE entry to real_sz even if that causes real_sz > to exceeds max_sz. This patch corrects the while loop logic > in those routines

Re: [PATCH] vmcore: prevent PT_NOTE p_memsz overflow during header update

2014-01-31 Thread Andrew Morton
On Fri, 31 Jan 2014 16:06:06 -0700 Greg Pearson wrote: > Currently, update_note_header_size_elf64() and > update_note_header_size_elf32() will add the size > of a PT_NOTE entry to real_sz even if that causes real_sz > to exceeds max_sz. This patch corrects the while loop logic > in those routines