Re: [PATCH] virtio_console: correct error message on failure of debugfs_create_dir

2012-12-24 Thread Greg Kroah-Hartman
On Mon, Dec 24, 2012 at 01:24:52PM -0500, Sasha Levin wrote: > On Mon, Dec 24, 2012 at 12:39 PM, Greg Kroah-Hartman > wrote: > > On Mon, Dec 24, 2012 at 11:55:46AM +, Arnd Bergmann wrote: > >> On Friday 21 December 2012, Amit Shah wrote: > >> > On (Thu) 20 Dec 2012 [14:11:21], Sasha Levin wrot

Re: [PATCH] virtio_console: correct error message on failure of debugfs_create_dir

2012-12-24 Thread Sasha Levin
On Mon, Dec 24, 2012 at 12:39 PM, Greg Kroah-Hartman wrote: > On Mon, Dec 24, 2012 at 11:55:46AM +, Arnd Bergmann wrote: >> On Friday 21 December 2012, Amit Shah wrote: >> > On (Thu) 20 Dec 2012 [14:11:21], Sasha Levin wrote: >> > > debugfs_create_dir() returns NULL if it fails, there's little

Re: [PATCH] virtio_console: correct error message on failure of debugfs_create_dir

2012-12-24 Thread Greg Kroah-Hartman
On Mon, Dec 24, 2012 at 11:55:46AM +, Arnd Bergmann wrote: > On Friday 21 December 2012, Amit Shah wrote: > > On (Thu) 20 Dec 2012 [14:11:21], Sasha Levin wrote: > > > debugfs_create_dir() returns NULL if it fails, there's little point in > > > calling PTR_ERR on it. > > > > debugfs_create_dir(

Re: [PATCH] virtio_console: correct error message on failure of debugfs_create_dir

2012-12-24 Thread Arnd Bergmann
On Friday 21 December 2012, Amit Shah wrote: > On (Thu) 20 Dec 2012 [14:11:21], Sasha Levin wrote: > > debugfs_create_dir() returns NULL if it fails, there's little point in > > calling PTR_ERR on it. > > debugfs_create_dir() does return an error value if debugfs is not > enabled. > > This check f

Re: [PATCH] virtio_console: correct error message on failure of debugfs_create_dir

2012-12-21 Thread Amit Shah
On (Thu) 20 Dec 2012 [14:11:21], Sasha Levin wrote: > debugfs_create_dir() returns NULL if it fails, there's little point in > calling PTR_ERR on it. > > Signed-off-by: Sasha Levin > --- > drivers/char/virtio_console.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --gi

[PATCH] virtio_console: correct error message on failure of debugfs_create_dir

2012-12-20 Thread Sasha Levin
debugfs_create_dir() returns NULL if it fails, there's little point in calling PTR_ERR on it. Signed-off-by: Sasha Levin --- drivers/char/virtio_console.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c inde