Re: [PATCH] virtio: console: Make resize control event handling compliant with spec

2025-03-27 Thread Amit Shah
On Thu, 2025-03-20 at 18:26 +0100, Maximilian Immanuel Brandtner wrote: > According to section 5.3.6.2 of the virtio spec a control buffer with > the event VIRITO_CONSOLE_RESIZE is followed by a > virtio_console_resize > struct containing 2 little endian 16bit integerts cols,rows. The > kernel > im

Re: [PATCH] virtio: console: Make resize control event handling compliant with spec

2025-03-23 Thread Halil Pasic
On Thu, 20 Mar 2025 18:26:54 +0100 Maximilian Immanuel Brandtner wrote: Let my try to do some nitpicking here. First on the subject. I would go with something more specific like "fix order of fields cols and rows", especially now that we have figured out the byte order handling is absent as well.

Re: [PATCH] virtio: console: Make resize control event handling compliant with spec

2025-03-20 Thread Maximilian Immanuel Brandtner
On Thu, 2025-03-20 at 18:26 +0100, Maximilian Immanuel Brandtner wrote: > According to section 5.3.6.2 of the virtio spec a control buffer with > the event VIRITO_CONSOLE_RESIZE is followed by a > virtio_console_resize > struct containing 2 little endian 16bit integerts cols,rows. The > kernel > im

[PATCH] virtio: console: Make resize control event handling compliant with spec

2025-03-20 Thread Maximilian Immanuel Brandtner
According to section 5.3.6.2 of the virtio spec a control buffer with the event VIRITO_CONSOLE_RESIZE is followed by a virtio_console_resize struct containing 2 little endian 16bit integerts cols,rows. The kernel implementation assums native endianness (which results in mangled values on big endian