Re: [PATCH] videobuf2: always re-init queue memory consistency attribute

On (20/06/10 12:17), Tomasz Figa wrote: [..] > > Is it OK with you if I fold this patch into the original patch series and > > make a > > new PR for it? I prefer to have a series merged without a bug, rather than > > fixing > > it in a final patch. > > I believe this didn't introduce any real bu

Re: [PATCH] videobuf2: always re-init queue memory consistency attribute

On Wed, Jun 10, 2020 at 11:54 AM Hans Verkuil wrote: > > Hi Sergey, > > On 09/06/2020 08:04, Sergey Senozhatsky wrote: > > We need a combination of two factors in order to permit modification > > of queue's memory consistency attribute in set_queue_consistency(): > > (1) queue should allow user-

Re: [PATCH] videobuf2: always re-init queue memory consistency attribute

Hi Hans, On (20/06/10 11:54), Hans Verkuil wrote: > > Is it OK with you if I fold this patch into the original patch series and > make a > new PR for it? I prefer to have a series merged without a bug, rather than > fixing > it in a final patch. Absolutely! -ss

Re: [PATCH] videobuf2: always re-init queue memory consistency attribute

Hi Sergey, On 09/06/2020 08:04, Sergey Senozhatsky wrote: > We need a combination of two factors in order to permit modification > of queue's memory consistency attribute in set_queue_consistency(): > (1) queue should allow user-space cache hints > (2) queue should be used for MMAP-ed I/O > >

[PATCH] videobuf2: always re-init queue memory consistency attribute

We need a combination of two factors in order to permit modification of queue's memory consistency attribute in set_queue_consistency(): (1) queue should allow user-space cache hints (2) queue should be used for MMAP-ed I/O Therefore the code in videobuf2 core looks as follows: q->mem