Re: [PATCH] video: xilinxfb: Fix compilation warning

2013-07-25 Thread Geert Uytterhoeven
On Wed, Jul 24, 2013 at 10:24 AM, Michal Simek wrote: >> Just now, I tested that the same problem happens on ARM config. >> Also, I solved it by adding '&' operator. >> >> '&' operator is necessary as below: >> >> dev_dbg(dev, "regs: phys=%pa, virt=%p\n", >> &drvdata->regs

Re: [PATCH] video: xilinxfb: Fix compilation warning

2013-07-24 Thread Michal Simek
On 07/24/2013 10:08 AM, Jingoo Han wrote: > On Wednesday, July 24, 2013 4:42 PM, Michal Simek wrote: >> On 07/24/2013 09:18 AM, Michal Simek wrote: >>> On 07/24/2013 08:00 AM, Jingoo Han wrote: On Wednesday, July 24, 2013 2:32 PM, Michal Simek wrote: > > regs_phys is phys_addr_t (u32 o

Re: [PATCH] video: xilinxfb: Fix compilation warning

2013-07-24 Thread Jingoo Han
On Wednesday, July 24, 2013 4:42 PM, Michal Simek wrote: > On 07/24/2013 09:18 AM, Michal Simek wrote: > > On 07/24/2013 08:00 AM, Jingoo Han wrote: > >> On Wednesday, July 24, 2013 2:32 PM, Michal Simek wrote: > >>> > >>> regs_phys is phys_addr_t (u32 or u64). > >>> Lets retype it to u64. > >>> >

Re: [PATCH] video: xilinxfb: Fix compilation warning

2013-07-24 Thread Michal Simek
On 07/24/2013 09:18 AM, Michal Simek wrote: > On 07/24/2013 08:00 AM, Jingoo Han wrote: >> On Wednesday, July 24, 2013 2:32 PM, Michal Simek wrote: >>> >>> regs_phys is phys_addr_t (u32 or u64). >>> Lets retype it to u64. >>> >>> Fixes compilation warning introduced by: >>> video: xilinxfb: Use drv

Re: [PATCH] video: xilinxfb: Fix compilation warning

2013-07-24 Thread Michal Simek
On 07/24/2013 08:00 AM, Jingoo Han wrote: > On Wednesday, July 24, 2013 2:32 PM, Michal Simek wrote: >> >> regs_phys is phys_addr_t (u32 or u64). >> Lets retype it to u64. >> >> Fixes compilation warning introduced by: >> video: xilinxfb: Use drvdata->regs_phys instead of physaddr >> (sha1: c88fafe

Re: [PATCH] video: xilinxfb: Fix compilation warning

2013-07-24 Thread Michal Simek
On 07/24/2013 08:05 AM, Vivek Subbarao wrote: > Why is there a necessity to type cast to unsigned long long ? Whats the > warning ? > Geerts: Build regressions/improvements in v3.11-rc2 + drivers/video/xilinxfb.c: warning: format '%x' expects argument of type 'unsigned int', but argument 4 ha

Re: [PATCH] video: xilinxfb: Fix compilation warning

2013-07-23 Thread Jingoo Han
On Wednesday, July 24, 2013 2:32 PM, Michal Simek wrote: > > regs_phys is phys_addr_t (u32 or u64). > Lets retype it to u64. > > Fixes compilation warning introduced by: > video: xilinxfb: Use drvdata->regs_phys instead of physaddr > (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81) CC'ed Stepan

[PATCH] video: xilinxfb: Fix compilation warning

2013-07-23 Thread Michal Simek
regs_phys is phys_addr_t (u32 or u64). Lets retype it to u64. Fixes compilation warning introduced by: video: xilinxfb: Use drvdata->regs_phys instead of physaddr (sha1: c88fafef0135e1e1c3e23c3e32ccbeeabc587f81) Signed-off-by: Michal Simek --- ppc44x_defconfig Fixes regressions in v3.11-rc2 ---