RE: [PATCH] vhost: use pr_err for vq_err

2024-05-16 Thread Peng Fan
> Subject: Re: [PATCH] vhost: use pr_err for vq_err > > On Thu, May 16, 2024 at 03:46:29PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > Use pr_err to print out error message without enabling DEBUG. This > > could make people catch error easier

Re: [PATCH] vhost: use pr_err for vq_err

2024-05-16 Thread Michael S. Tsirkin
On Thu, May 16, 2024 at 03:46:29PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Use pr_err to print out error message without enabling DEBUG. This could > make people catch error easier. > > Signed-off-by: Peng Fan This isn't appropriate: pr_err must not be triggerable by userspace. If yo

[PATCH] vhost: use pr_err for vq_err

2024-05-16 Thread Peng Fan (OSS)
From: Peng Fan Use pr_err to print out error message without enabling DEBUG. This could make people catch error easier. Signed-off-by: Peng Fan --- drivers/vhost/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index bb75