Re: [PATCH] vfs: remove redundant sanity check in do_mount

2014-09-12 Thread Seunghun Lee
On 09/13/2014 01:28 AM, Al Viro wrote: > On Sat, Sep 13, 2014 at 12:53:32AM +0900, Seunghun Lee wrote: >> In sys_mount, getname() checks dir_name. >> So do_mount needn't check dir_name again. > ... and simple grep shows four more call sites. At the very least, the > commit message needs to cover

Re: [PATCH] vfs: remove redundant sanity check in do_mount

2014-09-12 Thread Al Viro
On Sat, Sep 13, 2014 at 12:53:32AM +0900, Seunghun Lee wrote: > In sys_mount, getname() checks dir_name. > So do_mount needn't check dir_name again. ... and simple grep shows four more call sites. At the very least, the commit message needs to cover those as well, *if* the check is, indeed, redun

[PATCH] vfs: remove redundant sanity check in do_mount

2014-09-12 Thread Seunghun Lee
In sys_mount, getname() checks dir_name. So do_mount needn't check dir_name again. Signed-off-by: Seunghun Lee --- fs/namespace.c |5 - 1 file changed, 5 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index bfd03c6..bf8a9af 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@