Re: [PATCH] vfio-mdev/samples: Use u8 instead of char for handle functions

2018-12-17 Thread Alex Williamson
On Fri, 19 Oct 2018 11:04:27 -0700 Nathan Chancellor wrote: > Clang warns: > > samples/vfio-mdev/mtty.c:592:39: warning: implicit conversion from 'int' > to 'char' changes value from 162 to -94 [-Wconstant-conversion] > *buf = UART_MSR_DSR | UART_MSR_DDSR | UART_MSR_DCD; >

Re: [PATCH] vfio-mdev/samples: Use u8 instead of char for handle functions

2018-12-17 Thread Nathan Chancellor
On Fri, Oct 19, 2018 at 11:04:27AM -0700, Nathan Chancellor wrote: > Clang warns: > > samples/vfio-mdev/mtty.c:592:39: warning: implicit conversion from 'int' > to 'char' changes value from 162 to -94 [-Wconstant-conversion] > *buf = UART_MSR_DSR | UART_MSR_DDSR | UART_MSR_DCD; >

[PATCH] vfio-mdev/samples: Use u8 instead of char for handle functions

2018-10-19 Thread Nathan Chancellor
Clang warns: samples/vfio-mdev/mtty.c:592:39: warning: implicit conversion from 'int' to 'char' changes value from 162 to -94 [-Wconstant-conversion] *buf = UART_MSR_DSR | UART_MSR_DDSR | UART_MSR_DCD; ~ ~^~ 1 warning gen