Re: [PATCH] vfio: Use dev_printk() when possible

2019-03-29 Thread Alex Williamson
On Fri, 29 Mar 2019 12:03:11 -0500 Bjorn Helgaas wrote: > On Mon, Mar 25, 2019 at 3:49 PM Joe Perches wrote: > > > > On Mon, 2019-03-25 at 14:42 -0500, Bjorn Helgaas wrote: > > > Use dev_printk() when possible to make messages consistent with other > > > device-related messages. > > > > triv

Re: [PATCH] vfio: Use dev_printk() when possible

2019-03-29 Thread Bjorn Helgaas
On Mon, Mar 25, 2019 at 3:49 PM Joe Perches wrote: > > On Mon, 2019-03-25 at 14:42 -0500, Bjorn Helgaas wrote: > > Use dev_printk() when possible to make messages consistent with other > > device-related messages. > > trivial note: > > > diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxg

Re: [PATCH] vfio: Use dev_printk() when possible

2019-03-28 Thread Bjorn Helgaas
On Mon, Mar 25, 2019 at 5:00 PM Auger Eric wrote: > > Hi Bjorn, > On 3/25/19 8:42 PM, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > --- a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > > +++ b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > > @@ -89,7 +89,8 @@ static int vfio_pla

Re: [PATCH] vfio: Use dev_printk() when possible

2019-03-25 Thread Auger Eric
Hi Bjorn, On 3/25/19 8:42 PM, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Use dev_printk() when possible to make messages consistent with other > device-related messages> > Signed-off-by: Bjorn Helgaas > --- > drivers/vfio/pci/vfio_pci.c | 8 ++--- > drivers/vfio/pci/vfio_

Re: [PATCH] vfio: Use dev_printk() when possible

2019-03-25 Thread Joe Perches
On Mon, 2019-03-25 at 14:42 -0500, Bjorn Helgaas wrote: > Use dev_printk() when possible to make messages consistent with other > device-related messages. trivial note: > diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c > b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c [] >

[PATCH] vfio: Use dev_printk() when possible

2019-03-25 Thread Bjorn Helgaas
From: Bjorn Helgaas Use dev_printk() when possible to make messages consistent with other device-related messages. Signed-off-by: Bjorn Helgaas --- drivers/vfio/pci/vfio_pci.c | 8 ++--- drivers/vfio/pci/vfio_pci_config.c| 29 +-- .../platform/res