Re: [PATCH] vfio: Split virqfd into a separate module for vfio bus drivers

2015-03-19 Thread Paul Bolle
On Thu, 2015-03-19 at 14:12 -0600, Alex Williamson wrote: > Well, at some point when I was doing vfio it seemed like a good idea and > I copied it from another driver. For some time now I have this idea that there's a Linux kernel module template somewhere that uses defines like the ones you're us

Re: [PATCH] vfio: Split virqfd into a separate module for vfio bus drivers

2015-03-19 Thread Alex Williamson
On Thu, 2015-03-19 at 20:32 +0100, Paul Bolle wrote: > On Wed, 2015-03-18 at 11:27 -0600, Alex Williamson wrote: > > --- a/drivers/vfio/virqfd.c > > +++ b/drivers/vfio/virqfd.c > > > +#define DRIVER_VERSION "0.1" > > +#define DRIVER_AUTHOR "Alex Williamson " > > +#define DRIVER_DESC "IRQFD

Re: [PATCH] vfio: Split virqfd into a separate module for vfio bus drivers

2015-03-19 Thread Paul Bolle
On Wed, 2015-03-18 at 11:27 -0600, Alex Williamson wrote: > --- a/drivers/vfio/virqfd.c > +++ b/drivers/vfio/virqfd.c > +#define DRIVER_VERSION "0.1" > +#define DRIVER_AUTHOR "Alex Williamson " > +#define DRIVER_DESC "IRQFD support for VFIO bus drivers" > +MODULE_VERSION(DRIVER_VERSION); >

[PATCH] vfio: Split virqfd into a separate module for vfio bus drivers

2015-03-18 Thread Alex Williamson
An unintended consequence of commit 42ac9bd18d4f ("vfio: initialize the virqfd workqueue in VFIO generic code") is that the vfio module is renamed to vfio_core so that it can include both vfio and virqfd. That's a user visible change that may break module loading scritps and it imposes eventfd supp