Re: Re: Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-12 Thread Yongji Xie
On Mon, Aug 12, 2024 at 3:00 PM Jason Wang wrote: > > On Thu, Aug 8, 2024 at 6:52 PM Yongji Xie wrote: > > > > On Thu, Aug 8, 2024 at 10:58 AM Jason Wang wrote: > > > > > > On Wed, Aug 7, 2024 at 2:52 PM Yongji Xie wrote: > > > > > > > > On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > > >

Re: Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-12 Thread Jason Wang
On Thu, Aug 8, 2024 at 6:52 PM Yongji Xie wrote: > > On Thu, Aug 8, 2024 at 10:58 AM Jason Wang wrote: > > > > On Wed, Aug 7, 2024 at 2:52 PM Yongji Xie wrote: > > > > > > On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > > > > > > > Barry said [1]: > > > > > > > > """ > > > > mm doesn't sup

Re: Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-12 Thread Jason Wang
On Thu, Aug 8, 2024 at 7:09 PM Yongji Xie wrote: > > On Thu, Aug 8, 2024 at 1:50 PM Jason Wang wrote: > > > > On Wed, Aug 7, 2024 at 2:54 PM Yongji Xie wrote: > > > > > > On Wed, Aug 7, 2024 at 12:38 PM Jason Wang wrote: > > > > > > > > On Wed, Aug 7, 2024 at 11:13 AM Yongji Xie > > > > wrote

Re: Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-08 Thread Yongji Xie
On Thu, Aug 8, 2024 at 1:50 PM Jason Wang wrote: > > On Wed, Aug 7, 2024 at 2:54 PM Yongji Xie wrote: > > > > On Wed, Aug 7, 2024 at 12:38 PM Jason Wang wrote: > > > > > > On Wed, Aug 7, 2024 at 11:13 AM Yongji Xie > > > wrote: > > > > > > > > On Wed, Aug 7, 2024 at 10:39 AM Jason Wang wrote:

Re: Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-08 Thread Yongji Xie
On Thu, Aug 8, 2024 at 10:58 AM Jason Wang wrote: > > On Wed, Aug 7, 2024 at 2:52 PM Yongji Xie wrote: > > > > On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > > > > > Barry said [1]: > > > > > > """ > > > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > > > __GFP_NOFAIL w

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-07 Thread Jason Wang
On Wed, Aug 7, 2024 at 2:54 PM Yongji Xie wrote: > > On Wed, Aug 7, 2024 at 12:38 PM Jason Wang wrote: > > > > On Wed, Aug 7, 2024 at 11:13 AM Yongji Xie wrote: > > > > > > On Wed, Aug 7, 2024 at 10:39 AM Jason Wang wrote: > > > > > > > > On Tue, Aug 6, 2024 at 11:10 AM Yongji Xie > > > > wro

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-07 Thread Jason Wang
On Tue, Aug 6, 2024 at 10:30 AM Barry Song <21cn...@gmail.com> wrote: > > On Mon, Aug 5, 2024 at 8:21 PM Jason Wang wrote: > > > > Barry said [1]: > > > > """ > > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > > __GFP_NOFAIL without direct reclamation may just result in a busy

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-07 Thread Jason Wang
On Wed, Aug 7, 2024 at 2:52 PM Yongji Xie wrote: > > On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > > > Barry said [1]: > > > > """ > > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > > __GFP_NOFAIL without direct reclamation may just result in a busy > > loop within non

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-06 Thread Yongji Xie
On Wed, Aug 7, 2024 at 12:38 PM Jason Wang wrote: > > On Wed, Aug 7, 2024 at 11:13 AM Yongji Xie wrote: > > > > On Wed, Aug 7, 2024 at 10:39 AM Jason Wang wrote: > > > > > > On Tue, Aug 6, 2024 at 11:10 AM Yongji Xie > > > wrote: > > > > > > > > On Tue, Aug 6, 2024 at 10:28 AM Jason Wang wrot

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-06 Thread Yongji Xie
On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > Barry said [1]: > > """ > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > __GFP_NOFAIL without direct reclamation may just result in a busy > loop within non-sleepable contexts. > ""“ > > Unfortuantely, we do that under read

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-06 Thread Jason Wang
On Wed, Aug 7, 2024 at 11:13 AM Yongji Xie wrote: > > On Wed, Aug 7, 2024 at 10:39 AM Jason Wang wrote: > > > > On Tue, Aug 6, 2024 at 11:10 AM Yongji Xie wrote: > > > > > > On Tue, Aug 6, 2024 at 10:28 AM Jason Wang wrote: > > > > > > > > On Mon, Aug 5, 2024 at 6:42 PM Yongji Xie > > > > wro

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-06 Thread Yongji Xie
On Wed, Aug 7, 2024 at 10:39 AM Jason Wang wrote: > > On Tue, Aug 6, 2024 at 11:10 AM Yongji Xie wrote: > > > > On Tue, Aug 6, 2024 at 10:28 AM Jason Wang wrote: > > > > > > On Mon, Aug 5, 2024 at 6:42 PM Yongji Xie wrote: > > > > > > > > On Mon, Aug 5, 2024 at 4:24 PM Jason Wang wrote: > > >

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-06 Thread Jason Wang
On Tue, Aug 6, 2024 at 11:10 AM Yongji Xie wrote: > > On Tue, Aug 6, 2024 at 10:28 AM Jason Wang wrote: > > > > On Mon, Aug 5, 2024 at 6:42 PM Yongji Xie wrote: > > > > > > On Mon, Aug 5, 2024 at 4:24 PM Jason Wang wrote: > > > > > > > > On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > > >

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-05 Thread Yongji Xie
On Tue, Aug 6, 2024 at 10:28 AM Jason Wang wrote: > > On Mon, Aug 5, 2024 at 6:42 PM Yongji Xie wrote: > > > > On Mon, Aug 5, 2024 at 4:24 PM Jason Wang wrote: > > > > > > On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > > > > > > > Barry said [1]: > > > > > > > > """ > > > > mm doesn't sup

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-05 Thread Barry Song
On Mon, Aug 5, 2024 at 8:21 PM Jason Wang wrote: > > Barry said [1]: > > """ > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > __GFP_NOFAIL without direct reclamation may just result in a busy > loop within non-sleepable contexts. > ""“ the current code will result in returnin

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-05 Thread Jason Wang
On Mon, Aug 5, 2024 at 6:42 PM Yongji Xie wrote: > > On Mon, Aug 5, 2024 at 4:24 PM Jason Wang wrote: > > > > On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > > > > > Barry said [1]: > > > > > > """ > > > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > > > __GFP_NOFAIL wi

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-05 Thread Jason Wang
On Mon, Aug 5, 2024 at 4:26 PM Michael S. Tsirkin wrote: > > On Mon, Aug 05, 2024 at 04:21:06PM +0800, Jason Wang wrote: > > Barry said [1]: > > > > """ > > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > > __GFP_NOFAIL without direct reclamation may just result in a busy > > l

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-05 Thread Yongji Xie
On Mon, Aug 5, 2024 at 4:24 PM Jason Wang wrote: > > On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > > > Barry said [1]: > > > > """ > > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > > __GFP_NOFAIL without direct reclamation may just result in a busy > > loop within non

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-05 Thread Michael S. Tsirkin
On Mon, Aug 05, 2024 at 04:21:06PM +0800, Jason Wang wrote: > Barry said [1]: > > """ > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > __GFP_NOFAIL without direct reclamation may just result in a busy > loop within non-sleepable contexts. > ""“ > > Unfortuantely, we do that u

Re: [PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-05 Thread Jason Wang
On Mon, Aug 5, 2024 at 4:21 PM Jason Wang wrote: > > Barry said [1]: > > """ > mm doesn't support non-blockable __GFP_NOFAIL allocation. Because > __GFP_NOFAIL without direct reclamation may just result in a busy > loop within non-sleepable contexts. > ""“ > > Unfortuantely, we do that under read

[PATCH] vduse: avoid using __GFP_NOFAIL

2024-08-05 Thread Jason Wang
Barry said [1]: """ mm doesn't support non-blockable __GFP_NOFAIL allocation. Because __GFP_NOFAIL without direct reclamation may just result in a busy loop within non-sleepable contexts. ""“ Unfortuantely, we do that under read lock. A possible way to fix that is to move the pages allocation out