Re: [PATCH] v4l: fix build error for et61x251 driver

2007-09-14 Thread Mauro Carvalho Chehab
through ioctl()? It's not as immediate and safe as controlling the device registers through /sysfs (not /proc). However, the sysfs interface in those drivers appeared before V4L2 had its own ioctls and we agreed to keep and export the interface to the only users selecting CONFIG_VIDEO_ADV_DEBUG (o

Re: [PATCH] v4l: fix build error for et61x251 driver

2007-09-14 Thread Luca Risolia
On Friday 14 September 2007 14:50:11 Mauro Carvalho Chehab wrote: > > > > This patch is really ugly. > > > > Well, yes. I should have known as I converted so many occurences of > > to_video_device to container_of in my second patch. > > > > > > Why can't the "to_video_device()" macro be used? Just

Re: [PATCH] v4l: fix build error for et61x251 driver

2007-09-14 Thread Mauro Carvalho Chehab
> > > This patch is really ugly. > > Well, yes. I should have known as I converted so many occurences of > to_video_device to container_of in my second patch. > > > > Why can't the "to_video_device()" macro be used? Just move it to a place > > > where it's usable! IOW, what's wrong with the *much

Re: [PATCH] v4l: fix build error for et61x251 driver

2007-09-14 Thread aherrman
On Fri, Sep 14, 2007 at 03:53:06AM +0200, Luca Risolia wrote: > On Friday 14 September 2007 02:09:01 Linus Torvalds wrote: > > On Fri, 14 Sep 2007, Luca Risolia wrote: > > > Hacked-by: Luca Risolia <[EMAIL PROTECTED]> > > > > > > On Friday 14 September 2007 00:27:17 Andreas Herrmann wrote: > > > >

Re: [PATCH] v4l: fix build error for et61x251 driver

2007-09-13 Thread Luca Risolia
On Friday 14 September 2007 02:09:01 Linus Torvalds wrote: > On Fri, 14 Sep 2007, Luca Risolia wrote: > > Hacked-by: Luca Risolia <[EMAIL PROTECTED]> > > > > On Friday 14 September 2007 00:27:17 Andreas Herrmann wrote: > > > This fixes a kernel build problem and > > > should make it into 2.6.23, I

Re: [PATCH] v4l: fix build error for et61x251 driver

2007-09-13 Thread Linus Torvalds
On Fri, 14 Sep 2007, Luca Risolia wrote: > Hacked-by: Luca Risolia <[EMAIL PROTECTED]> > > On Friday 14 September 2007 00:27:17 Andreas Herrmann wrote: > > This fixes a kernel build problem and > > should make it into 2.6.23, I think. > > > > > > Regards, > > > > Andreas > > > > -- > > > > Get

Re: [PATCH] v4l: fix build error for et61x251 driver

2007-09-13 Thread Luca Risolia
Hacked-by: Luca Risolia <[EMAIL PROTECTED]> On Friday 14 September 2007 00:27:17 Andreas Herrmann wrote: > This fixes a kernel build problem and > should make it into 2.6.23, I think. > > > Regards, > > Andreas > > -- > > Get rid of some v4l1 remainders to avoid kernel build errors if > V4L1_COMPA

[PATCH] v4l: fix build error for et61x251 driver

2007-09-13 Thread Andreas Herrmann
This fixes a kernel build problem and should make it into 2.6.23, I think. Regards, Andreas -- Get rid of some v4l1 remainders to avoid kernel build errors if V4L1_COMPAT is not selected: drivers/media/video/et61x251/et61x251_core.c: In et61x251_show_: drivers/media/video/et61x251/et61x25