Re: [PATCH] utrace: remove exports

2007-05-03 Thread Alexey Dobriyan
On Mon, Apr 30, 2007 at 10:12:44AM +0100, Christoph Hellwig wrote: > On Sun, Apr 29, 2007 at 09:02:32PM -0700, Roland McGrath wrote: > > > EXPORT_SYMBOL_GPL(utrace_attach); > > > > > > There is not modular user of this, so this and the other utrace_ > > > functions should not be exported. Nor

Re: [PATCH] utrace: remove exports

2007-04-30 Thread Christoph Hellwig
On Sun, Apr 29, 2007 at 09:02:32PM -0700, Roland McGrath wrote: > > EXPORT_SYMBOL_GPL(utrace_attach); > > > > There is not modular user of this, so this and the other utrace_ > > functions should not be exported. Nor do I think that exporting > > such a low-level process control is ne

Re: [PATCH] utrace: remove exports

2007-04-29 Thread Roland McGrath
> All the exports in utrace are totally unused, and not really something > I'd want modules to use anyway :) Previously you said: > EXPORT_SYMBOL_GPL(utrace_attach); > > There is not modular user of this, so this and the other utrace_ > functions should not be exported. Nor do I thi

Re: [PATCH] utrace: remove exports

2007-04-18 Thread Jim Keniston
Christoph Hellwig wrote: > > All the exports in utrace are totally unused, and not really something > I'd want modules to use anyway :) > Please leave the exports in place. Very early in Documentation/utrace.txt, it says: "The UTRACE is infrastructure code for tracing and controlling user threa

[PATCH] utrace: remove exports

2007-04-18 Thread Christoph Hellwig
All the exports in utrace are totally unused, and not really something I'd want modules to use anyway :) Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/arch/i386/kernel/ptrace.c === --- linux-2.6.orig/arch/i38