Re: [PATCH] userspace API definitions for auto-focus coil

2016-07-13 Thread Pavel Machek
On Tue 2016-07-12 20:32:01, Mauro Carvalho Chehab wrote: > Em Sat, 18 Jun 2016 17:38:46 +0200 > Pavel Machek escreveu: > > > Hi! > > > > > > Not V4L2_CID_USER_AD5820...? > > > > > > The rest of the controls have no USER as part of the macro name, so I > > > wouldn't use it here either. > >

Re: [PATCH] userspace API definitions for auto-focus coil

2016-07-12 Thread Pavel Machek
On Tue 2016-07-12 20:32:01, Mauro Carvalho Chehab wrote: 1;2802;0c> Em Sat, 18 Jun 2016 17:38:46 +0200 > Pavel Machek escreveu: > > > Hi! > > > > > > Not V4L2_CID_USER_AD5820...? > > > > > > The rest of the controls have no USER as part of the macro name, so I > > > wouldn't use it here eithe

Re: [PATCH] userspace API definitions for auto-focus coil

2016-07-12 Thread Mauro Carvalho Chehab
Em Sat, 18 Jun 2016 17:38:46 +0200 Pavel Machek escreveu: > Hi! > > > > Not V4L2_CID_USER_AD5820...? > > > > The rest of the controls have no USER as part of the macro name, so I > > wouldn't use it here either. > > Ok. > > > > Ok, separate header file for 2 lines seemed like a bit of ove

Re: [PATCH] userspace API definitions for auto-focus coil

2016-06-18 Thread Pavel Machek
Hi! > > Not V4L2_CID_USER_AD5820...? > > The rest of the controls have no USER as part of the macro name, so I > wouldn't use it here either. Ok. > > Ok, separate header file for 2 lines seemed like a bit of overkill, > > but why not. > > That follows an existing pattern of how controls have b

Re: [PATCH] userspace API definitions for auto-focus coil

2016-06-17 Thread Sakari Ailus
Hi Pavel, On Mon, Jun 13, 2016 at 09:17:53PM +0200, Pavel Machek wrote: > On Sun 2016-06-12 14:22:53, Sakari Ailus wrote: > > Hi Pavel, > > > > On Sun, Jun 12, 2016 at 10:48:11AM +0200, Pavel Machek wrote: > > > Hi! > > > > > > > > >Add userspace API definitions. > > > > > > > > > > > >Signed-of

Re: [PATCH] userspace API definitions for auto-focus coil

2016-06-17 Thread Sakari Ailus
Hi Pavel, On Sun, Jun 12, 2016 at 09:54:17AM +0200, Pavel Machek wrote: > Hi! > > > > >@@ -974,4 +975,9 @@ enum v4l2_detect_md_mode { > > > > #define V4L2_CID_DETECT_MD_THRESHOLD_GRID > > > > (V4L2_CID_DETECT_CLASS_BASE + 3) > > > > #define V4L2_CID_DETECT_MD_REGION_GRID > > > >

Re: [PATCH] userspace API definitions for auto-focus coil

2016-06-13 Thread Pavel Machek
On Sun 2016-06-12 14:22:53, Sakari Ailus wrote: > Hi Pavel, > > On Sun, Jun 12, 2016 at 10:48:11AM +0200, Pavel Machek wrote: > > Hi! > > > > > > >Add userspace API definitions. > > > > > > > > > >Signed-off-by: Pavel Machek > > > > > > > > > >diff --git a/include/uapi/linux/v4l2-controls.h > >

Re: [PATCH] userspace API definitions for auto-focus coil

2016-06-12 Thread Sakari Ailus
Hi Pavel, On Sun, Jun 12, 2016 at 10:48:11AM +0200, Pavel Machek wrote: > Hi! > > > > >Add userspace API definitions. > > > > > > > >Signed-off-by: Pavel Machek > > > > > > > >diff --git a/include/uapi/linux/v4l2-controls.h > > > >b/include/uapi/linux/v4l2-controls.h > > > >index b6a357a..23011

Re: [PATCH] userspace API definitions for auto-focus coil

2016-06-12 Thread Pavel Machek
Hi! > > >Add userspace API definitions. > > > > > >Signed-off-by: Pavel Machek > > > > > >diff --git a/include/uapi/linux/v4l2-controls.h > > >b/include/uapi/linux/v4l2-controls.h > > >index b6a357a..23011cc 100644 > > >--- a/include/uapi/linux/v4l2-controls.h > > >+++ b/include/uapi/linux/v4l2-

Re: [PATCH] userspace API definitions for auto-focus coil

2016-06-12 Thread Pavel Machek
Hi! > > >@@ -974,4 +975,9 @@ enum v4l2_detect_md_mode { > > > #define V4L2_CID_DETECT_MD_THRESHOLD_GRID > > > (V4L2_CID_DETECT_CLASS_BASE + 3) > > > #define V4L2_CID_DETECT_MD_REGION_GRID > > > (V4L2_CID_DETECT_CLASS_BASE + 4) > > > > > >+/* Control IDs specific to the AD5820

Re: [PATCH] userspace API definitions for auto-focus coil

2016-06-11 Thread Sakari Ailus
Hi Ivaylo, On Mon, Jun 06, 2016 at 09:06:29AM +0300, Ivaylo Dimitrov wrote: > Hi, > > On 5.06.2016 22:07, Pavel Machek wrote: > >Add userspace API definitions. > > > >Signed-off-by: Pavel Machek > > > >diff --git a/include/uapi/linux/v4l2-controls.h > >b/include/uapi/linux/v4l2-controls.h > >i

Re: [PATCH] userspace API definitions for auto-focus coil

2016-06-06 Thread Pavel Machek
Hi! > On 5.06.2016 22:07, Pavel Machek wrote: > >Add userspace API definitions. > > > >Signed-off-by: Pavel Machek > > > >diff --git a/include/uapi/linux/v4l2-controls.h > >b/include/uapi/linux/v4l2-controls.h > >index b6a357a..23011cc 100644 > >--- a/include/uapi/linux/v4l2-controls.h > >+++ b

Re: [PATCH] userspace API definitions for auto-focus coil

2016-06-05 Thread Ivaylo Dimitrov
Hi, On 5.06.2016 22:07, Pavel Machek wrote: Add userspace API definitions. Signed-off-by: Pavel Machek diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h index b6a357a..23011cc 100644 --- a/include/uapi/linux/v4l2-controls.h +++ b/include/uapi/linux/v4l2-co

[PATCH] userspace API definitions for auto-focus coil

2016-06-05 Thread Pavel Machek
Add userspace API definitions. Signed-off-by: Pavel Machek diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h index b6a357a..23011cc 100644 --- a/include/uapi/linux/v4l2-controls.h +++ b/include/uapi/linux/v4l2-controls.h @@ -974,4 +975,9 @@ enum v4l2_detect_md