On Mon, May 15, 2017 at 09:07:10AM +0200, Moreno Bartalucci wrote:
>
> > Il giorno 12 mag 2017, alle ore 17:21, Bin Liu ha scritto:
> >
> > […]
> >
> > Moreno, would you mind to test the patch below with your modem?
> >
> > […]
> >>
> >>> 8<
> >>> diff --git a/drivers/usb
> Il giorno 12 mag 2017, alle ore 17:21, Bin Liu ha scritto:
>
> […]
>
> Moreno, would you mind to test the patch below with your modem?
>
> […]
>>
>>> 8<
>>> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
>>> index 9c7ee26ef388..465281244596 100
* Bin Liu [170512 10:43]:
> On Fri, May 12, 2017 at 10:21:35AM -0700, Tony Lindgren wrote:
> > * Bin Liu [170512 08:24]:
> > > On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote:
> > > > OK. No better ideas except I think we should probably have a separate
> > > > timer for keeping VBU
On Fri, May 12, 2017 at 10:21:35AM -0700, Tony Lindgren wrote:
> * Bin Liu [170512 08:24]:
> > On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote:
> > > OK. No better ideas except I think we should probably have a separate
> > > timer for keeping VBUS on after state changes eventually.
* Bin Liu [170512 08:24]:
> On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote:
> > OK. No better ideas except I think we should probably have a separate
> > timer for keeping VBUS on after state changes eventually.
>
> Currently with the patch below, VBUS is constantly on for host-onl
> Il giorno 12 mag 2017, alle ore 17:21, Bin Liu ha scritto:
>
> On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote:
>> * Bin Liu [170512 06:43]:
>>> On Thu, May 11, 2017 at 02:06:28PM -0700, Tony Lindgren wrote:
Well maybe the minimal fix for now is just pretty much back
On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote:
> * Bin Liu [170512 06:43]:
> > On Thu, May 11, 2017 at 02:06:28PM -0700, Tony Lindgren wrote:
> > >
> > > Well maybe the minimal fix for now is just pretty much back to
> > > square one of this thread. This should keep VBUS always on
* Bin Liu [170512 06:43]:
> On Thu, May 11, 2017 at 02:06:28PM -0700, Tony Lindgren wrote:
> >
> > Well maybe the minimal fix for now is just pretty much back to
> > square one of this thread. This should keep VBUS always on.
> > Then we can figure out some logic to cut VBUS later on.
> >
> > An
On Thu, May 11, 2017 at 02:06:28PM -0700, Tony Lindgren wrote:
>
> Well maybe the minimal fix for now is just pretty much back to
> square one of this thread. This should keep VBUS always on.
> Then we can figure out some logic to cut VBUS later on.
>
> And yeah, the state machine is really hard
* Bin Liu [170511 13:47]:
> On Thu, May 11, 2017 at 01:23:06PM -0700, Tony Lindgren wrote:
> >
> > Maybe try something like below, compile tested only. I don't
> > think I have any USB modem here to test with.
>
> The patch below doesn't help. In device detach by the time
> dsps_check_status() i
On Thu, May 11, 2017 at 01:23:06PM -0700, Tony Lindgren wrote:
> * Bin Liu [170511 13:05]:
> > On Thu, May 11, 2017 at 12:38:11PM -0700, Tony Lindgren wrote:
> > >
> > > I wonder if just keeping VBUS on longer in OTG_STATE_A_WAIT_BCON
> > > solves this issue?
> >
> > We don't cut VBUS intentiona
* Tony Lindgren [170511 13:26]:
> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> --- a/drivers/usb/musb/musb_dsps.c
> +++ b/drivers/usb/musb/musb_dsps.c
> @@ -270,6 +270,10 @@ static int dsps_check_status(struct musb *musb, void
> *unused)
> musb_writel(m
* Bin Liu [170511 13:05]:
> On Thu, May 11, 2017 at 12:38:11PM -0700, Tony Lindgren wrote:
> >
> > I wonder if just keeping VBUS on longer in OTG_STATE_A_WAIT_BCON
> > solves this issue?
>
> We don't cut VBUS intentionally for host mode (when devctl=0x19). The
> VBUS got cut in this case only be
On Thu, May 11, 2017 at 12:38:11PM -0700, Tony Lindgren wrote:
> * Bin Liu [170511 12:23]:
> > On Thu, May 11, 2017 at 02:10:05PM -0500, Bin Liu wrote:
> > [...]
> > > > > > The otg state machine implementation in the musb drivers are kind
> > > > > > of strange.
> > > > > > OTG_STATE_A_WAIT_BCON
* Bin Liu [170511 12:23]:
> On Thu, May 11, 2017 at 02:10:05PM -0500, Bin Liu wrote:
> [...]
> > > > > The otg state machine implementation in the musb drivers are kind of
> > > > > strange.
> > > > > OTG_STATE_A_WAIT_BCON suppose to be a steady state when no usb device
> > > > > is
> > > > > at
On Thu, May 11, 2017 at 02:10:05PM -0500, Bin Liu wrote:
[...]
> > > > The otg state machine implementation in the musb drivers are kind of
> > > > strange.
> > > > OTG_STATE_A_WAIT_BCON suppose to be a steady state when no usb device is
> > > > attached, but the musb drivers use it as a transient
On Thu, May 11, 2017 at 02:01:00PM -0500, Bin Liu wrote:
> On Thu, May 11, 2017 at 11:55:28AM -0700, Tony Lindgren wrote:
> > * Bin Liu [170511 11:53]:
> > > On Mon, Mar 27, 2017 at 10:55:37AM -0700, Tony Lindgren wrote:
> > > > * Bin Liu [170327 10:17]:
> > > > > On Mon, Mar 27, 2017 at 09:59:47
On Thu, May 11, 2017 at 11:55:28AM -0700, Tony Lindgren wrote:
> * Bin Liu [170511 11:53]:
> > On Mon, Mar 27, 2017 at 10:55:37AM -0700, Tony Lindgren wrote:
> > > * Bin Liu [170327 10:17]:
> > > > On Mon, Mar 27, 2017 at 09:59:47AM -0700, Tony Lindgren wrote:
> > > > > * Moreno Bartalucci [1703
* Bin Liu [170511 11:53]:
> On Mon, Mar 27, 2017 at 10:55:37AM -0700, Tony Lindgren wrote:
> > * Bin Liu [170327 10:17]:
> > > On Mon, Mar 27, 2017 at 09:59:47AM -0700, Tony Lindgren wrote:
> > > > * Moreno Bartalucci [170327 09:23]:
> > > > > If I understood your patch, however, if the device (
On Mon, Mar 27, 2017 at 10:55:37AM -0700, Tony Lindgren wrote:
> * Bin Liu [170327 10:17]:
> > On Mon, Mar 27, 2017 at 09:59:47AM -0700, Tony Lindgren wrote:
> > > * Moreno Bartalucci [170327 09:23]:
> > > > If I understood your patch, however, if the device (anyone, not just my
> > > > one) tak
* Moreno Bartalucci [170327 23:12]:
> > Il giorno 27 mar 2017, alle ore 19:15, Bin Liu ha scritto:
> >
> > […]
> >
> > The MUSB otg state machine has been changed in many place since the last
> > time I looked at it, and I am not sure how exactly it works now.
> >
> > If the $subject patch can
> Il giorno 27 mar 2017, alle ore 19:15, Bin Liu ha scritto:
>
> […]
>
> The MUSB otg state machine has been changed in many place since the last
> time I looked at it, and I am not sure how exactly it works now.
>
> If the $subject patch can correctly keep the VBUS on for host-only mode,
> we
* Bin Liu [170327 10:17]:
> On Mon, Mar 27, 2017 at 09:59:47AM -0700, Tony Lindgren wrote:
> > * Moreno Bartalucci [170327 09:23]:
> > > If I understood your patch, however, if the device (anyone, not just my
> > > one) takes longer to switch, VBUS is deasserted anyway.
> >
> > Yeah some of the
On Mon, Mar 27, 2017 at 09:59:47AM -0700, Tony Lindgren wrote:
> * Moreno Bartalucci [170327 09:23]:
> > If I understood your patch, however, if the device (anyone, not just my
> > one) takes longer to switch, VBUS is deasserted anyway.
>
> Yeah some of them can take at least 10 seconds even to
* Moreno Bartalucci [170327 09:23]:
> If I understood your patch, however, if the device (anyone, not just my one)
> takes longer to switch, VBUS is deasserted anyway.
Yeah some of them can take at least 10 seconds even to enumerate.
So probably we need to have to have some longer timeout set fo
> Il giorno 27 mar 2017, alle ore 16:30, Tony Lindgren ha
> scritto:
>
> […]
> I wonder if the following test patch allows the mode changing
> devices to been properly found? Of course it's just for testing,
> and scanning for devices takes now 5 seconds.. But it might
> provide clues why musb
* Bin Liu [170327 06:22]:
> On Mon, Mar 27, 2017 at 02:53:27PM +0200, Moreno Bartalucci wrote:
> > > Il giorno 25 mar 2017, alle ore 08:21, Lars Melin ha
> > > scritto:
> > >
> > >>
> > >> The usb device has been disconnected, why it still cares about VBUS
> > >> power?
> > >
> > > Morphing d
On Mon, Mar 27, 2017 at 02:53:27PM +0200, Moreno Bartalucci wrote:
> > Il giorno 25 mar 2017, alle ore 08:21, Lars Melin ha
> > scritto:
> >
> >>
> >> The usb device has been disconnected, why it still cares about VBUS
> >> power?
> >
> > Morphing devices (3G dongles, wifi dongles, some printe
> Il giorno 25 mar 2017, alle ore 08:21, Lars Melin ha
> scritto:
>
>>
>> The usb device has been disconnected, why it still cares about VBUS
>> power?
>
> Morphing devices (3G dongles, wifi dongles, some printers) boots up in
> install mode, usually only as a virtual cd-rom containing Window
On 2017-03-25 01:58, Bin Liu wrote:
On Wed, Mar 15, 2017 at 09:08:01AM -0500, Moreno Bartalucci wrote:
With usb-musb port in host mode, when the device
is disconnected, either logically (because of a mode switch) or
physically (by pulling the cable), the USB port should keep
suppling VBUS, with
On Wed, Mar 15, 2017 at 09:08:01AM -0500, Moreno Bartalucci wrote:
> With usb-musb port in host mode, when the device
> is disconnected, either logically (because of a mode switch) or
> physically (by pulling the cable), the USB port should keep
> suppling VBUS, with no interruption, to prevent pow
With usb-musb port in host mode, when the device
is disconnected, either logically (because of a mode switch) or
physically (by pulling the cable), the USB port should keep
suppling VBUS, with no interruption, to prevent power loss on
USB powered devices.
Signed-off-by: Moreno Bartalucci
---
dri
32 matches
Mail list logo
