Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-03-19 Thread Yuvaraj Cd
With this patch,I can see usb 3.0 device detection is failing on exynos5250-smdk5250 boards. CONFIG_USB_SUSPEND=n / $ [ 11.486922] hub 2-0:1.0: connect-debounce failed, port 1 disabled [ 13.891919] hub 2-0:1.0: connect-debounce failed, port 1 disabled [ 16.296919] hub 2-0:1.0: connect-deboun

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-08 Thread Sarah Sharp
On Wed, Jan 08, 2014 at 12:49:57PM -0500, Alan Stern wrote: > On Wed, 8 Jan 2014, Greg KH wrote: > > > On Wed, Jan 08, 2014 at 02:45:42PM +0800, Shen Guang wrote: > > > When we are doing compliance test with xHCI, we found that if we > > > enable CONFIG_USB_SUSPEND and plug in a bad device which c

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-08 Thread Alan Stern
On Wed, 8 Jan 2014, Greg KH wrote: > On Wed, Jan 08, 2014 at 02:45:42PM +0800, Shen Guang wrote: > > When we are doing compliance test with xHCI, we found that if we > > enable CONFIG_USB_SUSPEND and plug in a bad device which causes > > over-current condition to the root port, software will not b

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-08 Thread Greg KH
On Wed, Jan 08, 2014 at 02:45:42PM +0800, Shen Guang wrote: > When we are doing compliance test with xHCI, we found that if we > enable CONFIG_USB_SUSPEND and plug in a bad device which causes > over-current condition to the root port, software will not be noticed. > The reason is that current code

[PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-07 Thread Shen Guang
When we are doing compliance test with xHCI, we found that if we enable CONFIG_USB_SUSPEND and plug in a bad device which causes over-current condition to the root port, software will not be noticed. The reason is that current code don't set hub->change_bits in hub_activate() when over-current happ

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-07 Thread Greg KH
On Tue, Jan 07, 2014 at 02:38:36PM +0800, Shen Guang wrote: > On Tue, Jan 7, 2014 at 11:53 AM, Greg KH wrote: > > On Tue, Jan 07, 2014 at 11:35:50AM +0800, 沈光 wrote: > >> On Tue, Jan 7, 2014 at 10:40 AM, Greg KH > >> wrote: > >> > On Tue, Jan 07, 2014 at 10:33:14AM +0800, 沈光 wrote: > >> >> set h

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-06 Thread Shen Guang
On Tue, Jan 7, 2014 at 11:53 AM, Greg KH wrote: > On Tue, Jan 07, 2014 at 11:35:50AM +0800, 沈光 wrote: >> On Tue, Jan 7, 2014 at 10:40 AM, Greg KH wrote: >> > On Tue, Jan 07, 2014 at 10:33:14AM +0800, 沈光 wrote: >> >> set hub->change_bits when we plug in a device which causes >> >> over-current con

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-06 Thread Greg KH
On Tue, Jan 07, 2014 at 11:35:50AM +0800, 沈光 wrote: > On Tue, Jan 7, 2014 at 10:40 AM, Greg KH wrote: > > On Tue, Jan 07, 2014 at 10:33:14AM +0800, 沈光 wrote: > >> set hub->change_bits when we plug in a device which causes > >> over-current condition, so that hub_events() will check it. > > > > Why

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-06 Thread 沈光
On Tue, Jan 7, 2014 at 10:40 AM, Greg KH wrote: > On Tue, Jan 07, 2014 at 10:33:14AM +0800, 沈光 wrote: >> set hub->change_bits when we plug in a device which causes >> over-current condition, so that hub_events() will check it. > > Why? > > What does this solve? Is this a bug with existing devices

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-06 Thread Greg KH
On Tue, Jan 07, 2014 at 10:33:14AM +0800, 沈光 wrote: > set hub->change_bits when we plug in a device which causes > over-current condition, so that hub_events() will check it. Why? What does this solve? Is this a bug with existing devices that needs to be backported to older kernels? thanks, gr

[PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-06 Thread 沈光
set hub->change_bits when we plug in a device which causes over-current condition, so that hub_events() will check it. Signed-off-by: Shen Guang --- drivers/usb/core/hub.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c ind