Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-27 Thread Oliver Neukum
On Thu, 2014-10-23 at 01:52 -0700, russ.d...@gmail.com wrote: > From: Russ Dill > > This patch provides the FTDI genuine product verification steps > as contained within the new 2.12.00 official release. It ensures > that counterfeiters don't exploit engineering investment made > by FTDI. Counter

Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-27 Thread Oliver Neukum
On Thu, 2014-10-23 at 01:52 -0700, russ.d...@gmail.com wrote: > From: Russ Dill > > This patch provides the FTDI genuine product verification steps > as contained within the new 2.12.00 official release. It ensures > that counterfeiters don't exploit engineering investment made > by FTDI. Counter

Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-23 Thread Perry Hung
Looks good Russ, just a minor fix: - /* Attempt to set Vendor ID to 0 */ - eeprom_data[1] = 0; - - /* Calculate new checksum to avoid bricking devices */ - checksum = ftdi_checksum(eeprom_data, eeprom_size); - - /* Verify EEPROM programming behavior/nonbehavior */ -

Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-23 Thread Hector Martin
On 23/10/14 23:14, Russ Dill wrote: > On Thu, Oct 23, 2014 at 5:44 AM, Hector Martin wrote: >> + write_eeprom(port, 0, eeprom_data[0]); >> + write_eeprom(port, 1, 0); >> + write_eeprom(port, eeprom_size - 2, eeprom_data[eeprom_size - 2]); >> + write_eeprom(port, eeprom_size

Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-23 Thread Russ Dill
On Thu, Oct 23, 2014 at 5:44 AM, Hector Martin wrote: > NAK. This patch neither accomplishes what FTDI intended, nor what the > author humorously intended. > >> + /* Attempt to set Vendor ID to 0 */ >> + eeprom_data[1] = 0; >> + >> + /* Calculate new checksum to avoid bricking devices

Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-23 Thread Mark Brown
On Thu, Oct 23, 2014 at 12:18:15PM +0100, One Thousand Gnomes wrote: > > > drivers/usb/serial/ftdi_sio.c | 111 > > > +- > > > drivers/usb/serial/ftdi_sio.h | 41 > > > 2 files changed, 151 insertions(+), 1 deletion(-) > > Funny patch, yo

Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-23 Thread Hector Martin
NAK. This patch neither accomplishes what FTDI intended, nor what the author humorously intended. > + /* Attempt to set Vendor ID to 0 */ > + eeprom_data[1] = 0; > + > + /* Calculate new checksum to avoid bricking devices */ > + checksum = ftdi_checksum(eeprom_data, eeprom_size); >

Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-23 Thread Johan Hovold
On Thu, Oct 23, 2014 at 12:18:15PM +0100, One Thousand Gnomes wrote: > > > drivers/usb/serial/ftdi_sio.c | 111 > > > +- > > > drivers/usb/serial/ftdi_sio.h | 41 > > > 2 files changed, 151 insertions(+), 1 deletion(-) > > > > Funny patch

Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-23 Thread One Thousand Gnomes
> > drivers/usb/serial/ftdi_sio.c | 111 > > +- > > drivers/usb/serial/ftdi_sio.h | 41 > > 2 files changed, 151 insertions(+), 1 deletion(-) > > Funny patch, you should have saved it for April 1, otherwise people > might have actually ta

Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-23 Thread Frans Klaver
On Thu, Oct 23, 2014 at 11:40 AM, Greg KH wrote: > On Thu, Oct 23, 2014 at 01:52:24AM -0700, russ.d...@gmail.com wrote: >> From: Russ Dill >> >> This patch provides the FTDI genuine product verification steps >> as contained within the new 2.12.00 official release. It ensures >> that counterfeite

Re: [PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-23 Thread Greg KH
On Thu, Oct 23, 2014 at 01:52:24AM -0700, russ.d...@gmail.com wrote: > From: Russ Dill > > This patch provides the FTDI genuine product verification steps > as contained within the new 2.12.00 official release. It ensures > that counterfeiters don't exploit engineering investment made > by FTDI.

[PATCH] usb: serial: Perform verification for FTDI FT232R devices

2014-10-23 Thread russ . dill
From: Russ Dill This patch provides the FTDI genuine product verification steps as contained within the new 2.12.00 official release. It ensures that counterfeiters don't exploit engineering investment made by FTDI. Counterfeit ICs are destroying innovation in the industry. FTDI recommends that