Re: [PATCH] usb: renesas_usbhs: simplify list handling

2016-11-07 Thread Nicholas Mc Guire
On Tue, Nov 08, 2016 at 12:26:45PM +0900, Masahiro Yamada wrote: > >> Fixes: 6acb95d4e070 ("usb: renesas_usbhs: modify packet queue control > >> method") > > > This is not a fix, but a clean-up patch. true - I´ve been using it incorrectly to basically just record the origin of the issue found -

Re: [PATCH] usb: renesas_usbhs: simplify list handling

2016-11-07 Thread Masahiro Yamada
>> Fixes: 6acb95d4e070 ("usb: renesas_usbhs: modify packet queue control >> method") This is not a fix, but a clean-up patch. >> Signed-off-by: Nicholas Mc Guire >> --- >> Found by simple coccinelle scanner >> >> Compile tested with: multi_v7_defconfig (implies >> CONFIG_USB_RENESAS_USBHS=m)

RE: [PATCH] usb: renesas_usbhs: simplify list handling

2016-11-07 Thread Yoshihiro Shimoda
Hi, > From: Nicholas Mc Guire > Sent: Tuesday, November 08, 2016 4:07 AM > > The current code is effectively equivalent to list_first_entry_or_null() > so simply switch and simplify the code. > > Fixes: 6acb95d4e070 ("usb: renesas_usbhs: modify packet queue control method") > Signed-off-by: Nich

[PATCH] usb: renesas_usbhs: simplify list handling

2016-11-07 Thread Nicholas Mc Guire
The current code is effectively equivalent to list_first_entry_or_null() so simply switch and simplify the code. Fixes: 6acb95d4e070 ("usb: renesas_usbhs: modify packet queue control method") Signed-off-by: Nicholas Mc Guire --- Found by simple coccinelle scanner Compile tested with: multi_v7_de