Re: [PATCH] usb: musb: Fix format specifier warning

2013-06-01 Thread Andy Shevchenko
On Sat, Jun 1, 2013 at 8:11 PM, Emil Goode wrote: > Thank's for your pointers. > I will send a patch that applies on top of Felipe's patch. I guess there is not much sense to do that since Felipe applied your patch already. Just keep in mind the hint for future changes. -- With Best Regards, And

Re: [PATCH] usb: musb: Fix format specifier warning

2013-06-01 Thread Emil Goode
Hello, Thank's for your pointers. I will send a patch that applies on top of Felipe's patch. Best regards, Emil Goode On Sat, Jun 01, 2013 at 04:15:03PM +0300, Andy Shevchenko wrote: > On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap wrote: > > On 05/31/13 15:34, Andy Shevchenko wrote: > >> On Fri

Re: [PATCH] usb: musb: Fix format specifier warning

2013-06-01 Thread Andy Shevchenko
On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap wrote: > On 05/31/13 15:34, Andy Shevchenko wrote: >> On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: >>> This patch fixes a format specifier warning. dma_addr_t can be either >>> u32 or u64 so we should cast to the largest type and change the form

Re: [PATCH] usb: musb: Fix format specifier warning

2013-05-31 Thread Randy Dunlap
On 05/31/13 15:34, Andy Shevchenko wrote: > On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: >> This patch fixes a format specifier warning. dma_addr_t can be either >> u32 or u64 so we should cast to the largest type and change the format >> specifier to %llx. > > dma_addr_t is derived from p

Re: [PATCH] usb: musb: Fix format specifier warning

2013-05-31 Thread Andy Shevchenko
On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: > This patch fixes a format specifier warning. dma_addr_t can be either > u32 or u64 so we should cast to the largest type and change the format > specifier to %llx. dma_addr_t is derived from phys_addr_t, thus you may use %pa specifier which is

Re: [PATCH] usb: musb: Fix format specifier warning

2013-05-31 Thread Sergei Shtylyov
Hello. On 06/01/2013 12:22 AM, Emil Goode wrote: This patch fixes a format specifier warning. dma_addr_t can be either u32 or u64 so we should cast to the largest type and change the format specifier to %llx. The addition of urb->transfer_dma and urb->actual_length is also done a few lines belo

[PATCH] usb: musb: Fix format specifier warning

2013-05-31 Thread Emil Goode
This patch fixes a format specifier warning. dma_addr_t can be either u32 or u64 so we should cast to the largest type and change the format specifier to %llx. The addition of urb->transfer_dma and urb->actual_length is also done a few lines below. I have moved this code up and pass the variable bu