Re: [PATCH] usb: gadget: add claimed field in struct usb_ep

2014-06-30 Thread Robert Baldyga
On 06/30/2014 08:33 PM, Felipe Balbi wrote: > On Tue, Jun 24, 2014 at 02:16:35PM +0200, Robert Baldyga wrote: >> On 06/23/2014 08:27 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Mon, Jun 23, 2014 at 08:07:43AM +0200, Robert Baldyga wrote: On 06/19/2014 05:08 PM, Felipe Balbi wrote: > On Mon,

Re: [PATCH] usb: gadget: add claimed field in struct usb_ep

2014-06-30 Thread Felipe Balbi
On Tue, Jun 24, 2014 at 02:16:35PM +0200, Robert Baldyga wrote: > On 06/23/2014 08:27 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jun 23, 2014 at 08:07:43AM +0200, Robert Baldyga wrote: > >> On 06/19/2014 05:08 PM, Felipe Balbi wrote: > >>> On Mon, Jun 16, 2014 at 10:20:36AM +0200, Robert Bald

Re: [PATCH] usb: gadget: add claimed field in struct usb_ep

2014-06-24 Thread Robert Baldyga
On 06/23/2014 08:27 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jun 23, 2014 at 08:07:43AM +0200, Robert Baldyga wrote: >> On 06/19/2014 05:08 PM, Felipe Balbi wrote: >>> On Mon, Jun 16, 2014 at 10:20:36AM +0200, Robert Baldyga wrote: This field allows to mark ep as claimed in more clear way. C

Re: [PATCH] usb: gadget: add claimed field in struct usb_ep

2014-06-23 Thread Felipe Balbi
Hi, On Mon, Jun 23, 2014 at 08:07:43AM +0200, Robert Baldyga wrote: > On 06/19/2014 05:08 PM, Felipe Balbi wrote: > > On Mon, Jun 16, 2014 at 10:20:36AM +0200, Robert Baldyga wrote: > >> This field allows to mark ep as claimed in more clear way. Claiming > >> endpoint by setting driver_data to non

Re: [PATCH] usb: gadget: add claimed field in struct usb_ep

2014-06-22 Thread Robert Baldyga
On 06/19/2014 05:08 PM, Felipe Balbi wrote: > On Mon, Jun 16, 2014 at 10:20:36AM +0200, Robert Baldyga wrote: >> This field allows to mark ep as claimed in more clear way. Claiming >> endpoint by setting driver_data to non-null value is leaky solution >> and makes code unreadable. > > how come ? H

Re: [PATCH] usb: gadget: add claimed field in struct usb_ep

2014-06-19 Thread Felipe Balbi
On Mon, Jun 16, 2014 at 10:20:36AM +0200, Robert Baldyga wrote: > This field allows to mark ep as claimed in more clear way. Claiming > endpoint by setting driver_data to non-null value is leaky solution > and makes code unreadable. how come ? How can it be unreadable ? how can it be leaky ? --

[PATCH] usb: gadget: add claimed field in struct usb_ep

2014-06-16 Thread Robert Baldyga
This field allows to mark ep as claimed in more clear way. Claiming endpoint by setting driver_data to non-null value is leaky solution and makes code unreadable. Signed-off-by: Robert Baldyga --- drivers/usb/gadget/epautoconf.c | 11 ++- include/linux/usb/gadget.h | 1 + 2 files c