Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-11-26 Thread Felipe Balbi
On Mon, Oct 28, 2013 at 01:59:02PM +0100, Andreas Larsson wrote: > On 2013-10-01 16:19, Felipe Balbi wrote: > +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, > + int status) > +{ > + struct gr_udc *dev; > + > + list_del_init(&re

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-10-28 Thread Andreas Larsson
On 2013-10-01 16:19, Felipe Balbi wrote: +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, + int status) +{ + struct gr_udc *dev; + + list_del_init(&req->queue); + + if (likely(req->req.status == -EINPROGRESS)) + r

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-10-10 Thread Felipe Balbi
Hi, On Wed, Oct 02, 2013 at 10:52:06AM +0200, Andreas Larsson wrote: > >hmm, there are two ways to look at this. > > > >a) we have KERN_CONT to continue printing messages > >b) you might prefer using debugfs and seq_puts() for dumping large(-ish) > >amounts of debugging data ;-) > > I just found

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-10-02 Thread Andreas Larsson
On 2013-10-01 16:19, Felipe Balbi wrote: Hi, On Tue, Oct 01, 2013 at 10:34:47AM +0200, Andreas Larsson wrote: +/* #define VERBOSE_DEBUG */ we don't want this, we want verbose debug to be selectable on Kconfig, which already is ;-) I was only aware of CONFIG_USB_GADGET_DEBUG leading to DEBUG

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-10-01 Thread Felipe Balbi
Hi, On Tue, Oct 01, 2013 at 10:34:47AM +0200, Andreas Larsson wrote: > >>+/* #define VERBOSE_DEBUG */ > > > >we don't want this, we want verbose debug to be selectable on Kconfig, > >which already is ;-) > > I was only aware of CONFIG_USB_GADGET_DEBUG leading to DEBUG being > defined, not that an

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-10-01 Thread Andreas Larsson
Hi! Thank you for the feedback! Sorry for the delayed response back. Responses inline. On 2013-09-18 19:15, Felipe Balbi wrote: Hi, On Mon, Aug 12, 2013 at 04:05:10PM +0200, Andreas Larsson wrote: diff --git a/drivers/usb/gadget/gr_udc.c b/drivers/usb/gadget/gr_udc.c new file mode 100644 i

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-09-18 Thread Felipe Balbi
Hi, On Mon, Aug 12, 2013 at 04:05:10PM +0200, Andreas Larsson wrote: > diff --git a/drivers/usb/gadget/gr_udc.c b/drivers/usb/gadget/gr_udc.c > new file mode 100644 > index 000..37a6c08 > --- /dev/null > +++ b/drivers/usb/gadget/gr_udc.c > @@ -0,0 +1,2268 @@ > +/* > + * USB Peripheral Controll

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-09-17 Thread Felipe Balbi
Hi, On Mon, Sep 09, 2013 at 08:24:24AM -0700, Greg Kroah-Hartman wrote: > On Mon, Sep 09, 2013 at 07:33:31AM +0200, Andreas Larsson wrote: > > On 2013-08-28 11:02, Andreas Larsson wrote: > > > On 2013-08-12 16:05, Andreas Larsson wrote: > > >> This adds an UDC driver for GRUSBDC USB Device Control

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-09-09 Thread Greg Kroah-Hartman
On Mon, Sep 09, 2013 at 07:33:31AM +0200, Andreas Larsson wrote: > On 2013-08-28 11:02, Andreas Larsson wrote: > > On 2013-08-12 16:05, Andreas Larsson wrote: > >> This adds an UDC driver for GRUSBDC USB Device Controller cores > >> available in the > >> GRLIB VHDL IP core library. The driver only

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-09-08 Thread Andreas Larsson
On 2013-08-28 11:02, Andreas Larsson wrote: On 2013-08-12 16:05, Andreas Larsson wrote: This adds an UDC driver for GRUSBDC USB Device Controller cores available in the GRLIB VHDL IP core library. The driver only supports DMA mode. Any comments? It would be great to get feedback soon in case s

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-08-28 Thread Andreas Larsson
On 2013-08-12 16:05, Andreas Larsson wrote: This adds an UDC driver for GRUSBDC USB Device Controller cores available in the GRLIB VHDL IP core library. The driver only supports DMA mode. Any comments? It would be great to get feedback soon in case some things need to be changed for this drive