Re: [PATCH] usb: fix unterminated usn_device_id lists

2007-09-12 Thread Jeff Garzik
Kees Cook wrote: Hi, On Wed, Sep 12, 2007 at 09:15:07PM -0400, Jeff Garzik wrote: + { 0, }, FWIW I (and several drivers) tend to prefer the more clean version, { }, or even { },/* terminate list */ Ah, yes. I see that now in some of the other drivers. Should I

Re: [PATCH] usb: fix unterminated usn_device_id lists

2007-09-12 Thread Kees Cook
Hi, On Wed, Sep 12, 2007 at 09:15:07PM -0400, Jeff Garzik wrote: >> +{ 0, }, > > FWIW I (and several drivers) tend to prefer the more clean version, > > { }, > > or even > > { },/* terminate list */ Ah, yes. I see that now in some of the other drivers. Should I re-send this

Re: [PATCH] usb: fix unterminated usn_device_id lists

2007-09-12 Thread Jeff Garzik
Kees Cook wrote: This patch against 2.6.23-rc6 fixes a unterminated list of USB device ids. Signed-off-by: Kees Cook <[EMAIL PROTECTED]> --- linux-2.6.23-rc6/drivers/media/video/usbvision/usbvision-cards.c |1 + 1 file changed, 1 insertion(+) --- diff -urp -x '*.o' linux-2.6.23-rc6~/driver

[PATCH] usb: fix unterminated usn_device_id lists

2007-09-12 Thread Kees Cook
This patch against 2.6.23-rc6 fixes a unterminated list of USB device ids. Signed-off-by: Kees Cook <[EMAIL PROTECTED]> --- linux-2.6.23-rc6/drivers/media/video/usbvision/usbvision-cards.c |1 + 1 file changed, 1 insertion(+) --- diff -urp -x '*.o' linux-2.6.23-rc6~/drivers/media/video/usbvi