Re: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-29 Thread Alan Stern
On Fri, 29 Mar 2013, Tony Prisk wrote: > On 29/03/13 10:16, Arnd Bergmann wrote: > > On Thursday 28 March 2013, Arnd Bergmann wrote: > >> Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used > >> with CONFIG_PM" tried to hide the unlink_empty_async_suspended function > >> inside o

Re: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-29 Thread Alan Stern
On Thu, 28 Mar 2013, Arnd Bergmann wrote: > Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used > with CONFIG_PM" tried to hide the unlink_empty_async_suspended function > inside of an #ifdef to work around an unused function warning. > > Unfortunately that had the effect of int

Re: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-28 Thread Tony Prisk
On 29/03/13 10:16, Arnd Bergmann wrote: On Thursday 28 March 2013, Arnd Bergmann wrote: Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM" tried to hide the unlink_empty_async_suspended function inside of an #ifdef to work around an unused function warning. Hi

Re: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-28 Thread Arnd Bergmann
On Thursday 28 March 2013, Arnd Bergmann wrote: > Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used > with CONFIG_PM" tried to hide the unlink_empty_async_suspended function > inside of an #ifdef to work around an unused function warning. Hi Greg, Apparently the warning is now

[PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-28 Thread Arnd Bergmann
Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM" tried to hide the unlink_empty_async_suspended function inside of an #ifdef to work around an unused function warning. Unfortunately that had the effect of introducing a new warning: drivers/usb/host/ehci-q.c:12