Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-04 Thread Philipp Zabel
On Wed, 2018-04-04 at 10:25 +0900, Masahiro Yamada wrote: > 2018-04-03 19:35 GMT+09:00 Vivek Gautam : > > > > > > On 4/3/2018 3:49 PM, Masahiro Yamada wrote: > > > > > > 2018-04-03 17:46 GMT+09:00 Philipp Zabel : > > > > > > > > On Tue, 2018-04-03 at 17:30 +0900, Masahiro Yamada wrote: > > > >

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-03 Thread Masahiro Yamada
2018-04-03 19:35 GMT+09:00 Vivek Gautam : > > > On 4/3/2018 3:49 PM, Masahiro Yamada wrote: >> >> 2018-04-03 17:46 GMT+09:00 Philipp Zabel : >>> >>> On Tue, 2018-04-03 at 17:30 +0900, Masahiro Yamada wrote: 2018-04-03 17:00 GMT+09:00 Philipp Zabel : > > On Thu, 2018-03-29 at 15:07

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-03 Thread Vivek Gautam
On 4/3/2018 3:49 PM, Masahiro Yamada wrote: 2018-04-03 17:46 GMT+09:00 Philipp Zabel : On Tue, 2018-04-03 at 17:30 +0900, Masahiro Yamada wrote: 2018-04-03 17:00 GMT+09:00 Philipp Zabel : On Thu, 2018-03-29 at 15:07 +0900, Masahiro Yamada wrote: This driver handles the reset control in a co

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-03 Thread Masahiro Yamada
2018-04-03 17:46 GMT+09:00 Philipp Zabel : > On Tue, 2018-04-03 at 17:30 +0900, Masahiro Yamada wrote: >> 2018-04-03 17:00 GMT+09:00 Philipp Zabel : >> > On Thu, 2018-03-29 at 15:07 +0900, Masahiro Yamada wrote: >> > > This driver handles the reset control in a common manner; deassert >> > > resets

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-03 Thread Philipp Zabel
On Tue, 2018-04-03 at 17:30 +0900, Masahiro Yamada wrote: > 2018-04-03 17:00 GMT+09:00 Philipp Zabel : > > On Thu, 2018-03-29 at 15:07 +0900, Masahiro Yamada wrote: > > > This driver handles the reset control in a common manner; deassert > > > resets before use, assert them after use. There is no

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-03 Thread Masahiro Yamada
2018-04-03 17:00 GMT+09:00 Philipp Zabel : > On Thu, 2018-03-29 at 15:07 +0900, Masahiro Yamada wrote: >> This driver handles the reset control in a common manner; deassert >> resets before use, assert them after use. There is no good reason >> why it should be exclusive. > > Is this preemptive cl

Re: [PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-04-03 Thread Philipp Zabel
On Thu, 2018-03-29 at 15:07 +0900, Masahiro Yamada wrote: > This driver handles the reset control in a common manner; deassert > resets before use, assert them after use. There is no good reason > why it should be exclusive. Is this preemptive cleanup, or do you have hardware on the horizon that

[PATCH] usb: dwc3: of-simple: use managed and shared reset control

2018-03-28 Thread Masahiro Yamada
This driver handles the reset control in a common manner; deassert resets before use, assert them after use. There is no good reason why it should be exclusive. Also, use devm_ for clean-up. Signed-off-by: Masahiro Yamada --- CCing Philipp Zabel. I see his sob in commit 06c47e6286d5. driver