Re: [PATCH] update sc->nr_reclaimed after each shrink_slab

2016-07-22 Thread Vladimir Davydov
On Fri, Jul 22, 2016 at 09:49:13AM +0200, Michal Hocko wrote: > On Fri 22-07-16 11:43:30, Zhou Chengming wrote: > > In !global_reclaim(sc) case, we should update sc->nr_reclaimed after each > > shrink_slab in the loop. Because we need the correct sc->nr_reclaimed > > value to see if we can break ou

Re: [PATCH] update sc->nr_reclaimed after each shrink_slab

2016-07-22 Thread Michal Hocko
On Fri 22-07-16 11:12:59, Vladimir Davydov wrote: > On Fri, Jul 22, 2016 at 09:49:13AM +0200, Michal Hocko wrote: > > On Fri 22-07-16 11:43:30, Zhou Chengming wrote: > > > In !global_reclaim(sc) case, we should update sc->nr_reclaimed after each > > > shrink_slab in the loop. Because we need the co

Re: [PATCH] update sc->nr_reclaimed after each shrink_slab

2016-07-22 Thread Michal Hocko
On Fri 22-07-16 11:43:30, Zhou Chengming wrote: > In !global_reclaim(sc) case, we should update sc->nr_reclaimed after each > shrink_slab in the loop. Because we need the correct sc->nr_reclaimed > value to see if we can break out. Does this actually change anything? Maybe I am missing something b

[PATCH] update sc->nr_reclaimed after each shrink_slab

2016-07-21 Thread Zhou Chengming
In !global_reclaim(sc) case, we should update sc->nr_reclaimed after each shrink_slab in the loop. Because we need the correct sc->nr_reclaimed value to see if we can break out. Signed-off-by: Zhou Chengming --- mm/vmscan.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --g