Re: [PATCH] unlz4: always set an error return code on failures

2013-11-11 Thread Jan Beulich
>>> On 11.11.13 at 14:02, Kyungsik Lee wrote: > On Mon, Nov 11, 2013 at 08:35:31AM +, Jan Beulich wrote: >> >>> On 11.11.13 at 03:49, Kyungsik Lee wrote: >> > Hello Jan, >> > >> > Thanks for the patch. >> > >> > On Fri, Nov 08, 2013 at 09:27:09AM +, Jan Beulich wrote: >> >> "ret", being

Re: [PATCH] unlz4: always set an error return code on failures

2013-11-11 Thread Kyungsik Lee
On Mon, Nov 11, 2013 at 08:35:31AM +, Jan Beulich wrote: > >>> On 11.11.13 at 03:49, Kyungsik Lee wrote: > > Hello Jan, > > > > Thanks for the patch. > > > > On Fri, Nov 08, 2013 at 09:27:09AM +, Jan Beulich wrote: > >> "ret", being set to -1 early on, gets cleared by the first invocatio

Re: [PATCH] unlz4: always set an error return code on failures

2013-11-11 Thread Jan Beulich
>>> On 11.11.13 at 03:49, Kyungsik Lee wrote: > Hello Jan, > > Thanks for the patch. > > On Fri, Nov 08, 2013 at 09:27:09AM +, Jan Beulich wrote: >> "ret", being set to -1 early on, gets cleared by the first invocation >> of lz4_decompress()/lz4_decompress_unknownoutputsize(), and hence >> s

Re: [PATCH] unlz4: always set an error return code on failures

2013-11-10 Thread Kyungsik Lee
Hello Jan, Thanks for the patch. On Fri, Nov 08, 2013 at 09:27:09AM +, Jan Beulich wrote: > "ret", being set to -1 early on, gets cleared by the first invocation > of lz4_decompress()/lz4_decompress_unknownoutputsize(), and hence > subsequent failures wouldn't be noticed by the caller without

[PATCH] unlz4: always set an error return code on failures

2013-11-08 Thread Jan Beulich
"ret", being set to -1 early on, gets cleared by the first invocation of lz4_decompress()/lz4_decompress_unknownoutputsize(), and hence subsequent failures wouldn't be noticed by the caller without setting it back to -1 right after those calls. Reported-by: Matthew Daley Signed-off-by: Jan Beulic