Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Greg KH
gust 11, 2014 1:58 PM > To: Sharma, Sanjeev > Cc: hdego...@redhat.com; kra...@redhat.com; mdharm-...@one-eyed-alien.net; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-s...@vger.kernel.org > Subject: Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locke

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Hans de Goede
Hi, On 08/11/2014 09:08 PM, Guenter Roeck wrote: > On Mon, Aug 11, 2014 at 08:55:07PM +0200, Hans de Goede wrote: >> Hi, >> >> On 08/11/2014 08:19 PM, Guenter Roeck wrote: >>> On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote: spin_is_locked() always return false in uniprocessor

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Guenter Roeck
On Mon, Aug 11, 2014 at 08:55:07PM +0200, Hans de Goede wrote: > Hi, > > On 08/11/2014 08:19 PM, Guenter Roeck wrote: > > On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote: > >> spin_is_locked() always return false in uniprocessor configuration and > >> therefore it > >> would be adv

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Hans de Goede
Hi, On 08/11/2014 09:59 AM, Sanjeev Sharma wrote: > spin_is_locked() always return false in uniprocessor configuration and > therefore it > would be advise to repalce with assert_spin_locked(). > > Signed-off-by: Sanjeev Sharma Looks sane / good to me: Acked-by: Hans de Goede Regards, Hans

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Hans de Goede
Hi, On 08/11/2014 08:19 PM, Guenter Roeck wrote: > On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote: >> spin_is_locked() always return false in uniprocessor configuration and >> therefore it >> would be advise to repalce with assert_spin_locked(). >> >> Signed-off-by: Sanjeev Sharma

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Guenter Roeck
On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote: > spin_is_locked() always return false in uniprocessor configuration and > therefore it > would be advise to repalce with assert_spin_locked(). > > Signed-off-by: Sanjeev Sharma > --- > drivers/usb/storage/uas.c | 8 > 1 f

RE: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Sharma, Sanjeev
@vger.kernel.org; linux-s...@vger.kernel.org Subject: Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked(). On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote: > spin_is_locked() always return false in uniprocessor configuration Really? On what processor type? I don&#x

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Greg KH
On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote: > spin_is_locked() always return false in uniprocessor configuration Really? On what processor type? I don't see that being the case on a few processors, but I didn't check them all, or I might be totally confused with all of the ar

[PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Sanjeev Sharma
spin_is_locked() always return false in uniprocessor configuration and therefore it would be advise to repalce with assert_spin_locked(). Signed-off-by: Sanjeev Sharma --- drivers/usb/storage/uas.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/storage/u