Re: [PATCH] tun: don't look at current when non-blocking

2013-10-09 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 9 Oct 2013 11:13:54 +0300 > On Wed, Oct 09, 2013 at 02:25:19PM +0800, Jason Wang wrote: >> On 10/09/2013 03:46 AM, David Miller wrote: >> > From: "Michael S. Tsirkin" >> > Date: Sun, 6 Oct 2013 21:25:12 +0300 >> > >> >> We play with a wait queue even if sock

Re: [PATCH] tun: don't look at current when non-blocking

2013-10-09 Thread Michael S. Tsirkin
On Wed, Oct 09, 2013 at 02:25:19PM +0800, Jason Wang wrote: > On 10/09/2013 03:46 AM, David Miller wrote: > > From: "Michael S. Tsirkin" > > Date: Sun, 6 Oct 2013 21:25:12 +0300 > > > >> We play with a wait queue even if socket is > >> non blocking. This is an obvious waste. > >> Besides, it will

Re: [PATCH] tun: don't look at current when non-blocking

2013-10-08 Thread Jason Wang
On 10/09/2013 03:46 AM, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Sun, 6 Oct 2013 21:25:12 +0300 > >> We play with a wait queue even if socket is >> non blocking. This is an obvious waste. >> Besides, it will prevent calling the non blocking >> variant when current is not valid. >>

Re: [PATCH] tun: don't look at current when non-blocking

2013-10-08 Thread David Miller
From: "Michael S. Tsirkin" Date: Sun, 6 Oct 2013 21:25:12 +0300 > We play with a wait queue even if socket is > non blocking. This is an obvious waste. > Besides, it will prevent calling the non blocking > variant when current is not valid. > > Signed-off-by: Michael S. Tsirkin Applied and que

Re: [PATCH] tun: don't look at current when non-blocking

2013-10-07 Thread Jason Wang
On 10/07/2013 02:25 AM, Michael S. Tsirkin wrote: > We play with a wait queue even if socket is > non blocking. This is an obvious waste. > Besides, it will prevent calling the non blocking > variant when current is not valid. > > Signed-off-by: Michael S. Tsirkin > --- Acked-by: Jason Wang > d

[PATCH] tun: don't look at current when non-blocking

2013-10-06 Thread Michael S. Tsirkin
We play with a wait queue even if socket is non blocking. This is an obvious waste. Besides, it will prevent calling the non blocking variant when current is not valid. Signed-off-by: Michael S. Tsirkin --- drivers/net/tun.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --g