Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-29 Thread Pramod Gurav
Hi Stephen, Thanks for having a look. On 26 August 2016 at 04:20, Stephen Boyd wrote: > On 06/17, Pramod Gurav wrote: >> @@ -1220,12 +1293,26 @@ static void msm_power(struct uart_port *port, >> unsigned int state, >> >> switch (state) { >> case 0: >> - clk_prepare_enable

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-25 Thread Stephen Boyd
On 06/17, Pramod Gurav wrote: > @@ -1220,12 +1293,26 @@ static void msm_power(struct uart_port *port, > unsigned int state, > > switch (state) { > case 0: > - clk_prepare_enable(msm_port->clk); > - clk_prepare_enable(msm_port->pclk); > + /* > +

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-24 Thread Pramod Gurav
Hi, On 17 June 2016 at 15:46, Pramod Gurav wrote: > Add runtime pm and suspend/resume callback support to serial msm > driver so that clock resources are managed runtime to save power. > Any comments on this patch? > Signed-off-by: Pramod Gurav > --- > drivers/tty/serial/msm_serial.c | 183 >

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-24 Thread Pramod Gurav
On 25 August 2016 at 10:05, Andy Gross wrote: > On 17 June 2016 at 05:16, Pramod Gurav wrote: > >> + if (msm_port->is_uartdm) { >> + ret = clk_enable(msm_port->pclk); > > Ditto here. Thanks Andy, will include these two changes in v2. > >> + if (ret)

Re: [PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-08-24 Thread Andy Gross
On 17 June 2016 at 05:16, Pramod Gurav wrote: > @@ -1635,6 +1732,7 @@ static int msm_serial_remove(struct platform_device > *pdev) > struct uart_port *port = platform_get_drvdata(pdev); > > uart_remove_one_port(&msm_uart_driver, port); > + pm_runtime_disable(&pdev->dev);

[PATCH] tty: serial: msm: Add runtime PM and system sleep support

2016-06-17 Thread Pramod Gurav
Add runtime pm and suspend/resume callback support to serial msm driver so that clock resources are managed runtime to save power. Signed-off-by: Pramod Gurav --- drivers/tty/serial/msm_serial.c | 183 1 file changed, 168 insertions(+), 15 deletions(-) d