Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-05-03 Thread Vignesh R
Hi, On 04/12/2016 10:33 PM, Sebastian Andrzej Siewior wrote: > On 04/11/2016 10:10 PM, Peter Hurley wrote: >> On 04/11/2016 11:31 AM, Sebastian Andrzej Siewior wrote: >>> On 04/11/2016 07:53 PM, Peter Hurley wrote: On 04/11/2016 01:18 AM, John Ogness wrote: > On 2016-04-05, Peter Hurley

Re: 8250 dma issues ( was Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes)

2016-04-14 Thread Peter Hurley
On 04/14/2016 08:07 AM, One Thousand Gnomes wrote: 3. Handling XON/XOFF transmit is mandatory; I don't see a way to do that without pause/resume. >>> >>> Yes, not doing XON/XOFF with DMA is not good. Using hardware flow >>> control is one workaround but the user has no chance of know

Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-04-14 Thread Peter Hurley
On 04/12/2016 11:42 AM, Peter Hurley wrote: > On 04/12/2016 10:03 AM, Sebastian Andrzej Siewior wrote: >> On 04/11/2016 10:10 PM, Peter Hurley wrote: >>> On 04/11/2016 11:31 AM, Sebastian Andrzej Siewior wrote: On 04/11/2016 07:53 PM, Peter Hurley wrote: > On 04/11/2016 01:18 AM, John Ogne

Re: 8250 dma issues ( was Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes)

2016-04-14 Thread One Thousand Gnomes
> >> 3. Handling XON/XOFF transmit is mandatory; I don't see a way to do that > >>without pause/resume. > > > > Yes, not doing XON/XOFF with DMA is not good. Using hardware flow > > control is one workaround but the user has no chance of knowing that > > XON/XOFF has been silently disabled.

Re: omap uart + dma issues (Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes)

2016-04-13 Thread Peter Hurley
On 04/13/2016 04:11 AM, Sekhar Nori wrote: > On Wednesday 13 April 2016 05:30 AM, Peter Hurley wrote: > - generates spurious uart interrupt for every rx dma transaction (ie., necessitates acking every UART interrupt, even UART_IIR_NO_INT) _Even with this workaround_, it still ge

Re: omap uart + dma issues (Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes)

2016-04-13 Thread Sekhar Nori
On Wednesday 13 April 2016 05:30 AM, Peter Hurley wrote: >>> - generates spurious uart interrupt for every rx dma transaction >>> (ie., necessitates acking every UART interrupt, even UART_IIR_NO_INT) >>> _Even with this workaround_, it still generates spurious interrupt warning >>> which shu

omap uart + dma issues (Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes)

2016-04-12 Thread Peter Hurley
On 04/12/2016 10:03 AM, Sebastian Andrzej Siewior wrote: > On 04/11/2016 10:10 PM, Peter Hurley wrote: >> On 04/11/2016 11:31 AM, Sebastian Andrzej Siewior wrote: >>> On 04/11/2016 07:53 PM, Peter Hurley wrote: On 04/11/2016 01:18 AM, John Ogness wrote: > On 2016-04-05, Peter Hurley wrote

8250 dma issues ( was Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes)

2016-04-12 Thread Peter Hurley
[ +to Heikki, Andy ] On 04/12/2016 10:03 AM, Sebastian Andrzej Siewior wrote: > On 04/11/2016 10:10 PM, Peter Hurley wrote: >> On 04/11/2016 11:31 AM, Sebastian Andrzej Siewior wrote: >>> On 04/11/2016 07:53 PM, Peter Hurley wrote: [ elided parts not relevant to shared 8250 dma discussion ] >> 2

Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-04-12 Thread Peter Hurley
On 04/12/2016 10:03 AM, Sebastian Andrzej Siewior wrote: > On 04/11/2016 10:10 PM, Peter Hurley wrote: >> On 04/11/2016 11:31 AM, Sebastian Andrzej Siewior wrote: >>> On 04/11/2016 07:53 PM, Peter Hurley wrote: On 04/11/2016 01:18 AM, John Ogness wrote: > On 2016-04-05, Peter Hurley wrote

Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-04-12 Thread Sebastian Andrzej Siewior
On 04/11/2016 10:10 PM, Peter Hurley wrote: > On 04/11/2016 11:31 AM, Sebastian Andrzej Siewior wrote: >> On 04/11/2016 07:53 PM, Peter Hurley wrote: >>> On 04/11/2016 01:18 AM, John Ogness wrote: On 2016-04-05, Peter Hurley wrote: > On 03/31/2016 01:41 AM, John Ogness wrote: >> It ha

Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-04-11 Thread Peter Hurley
On 04/11/2016 11:31 AM, Sebastian Andrzej Siewior wrote: > On 04/11/2016 07:53 PM, Peter Hurley wrote: >> On 04/11/2016 01:18 AM, John Ogness wrote: >>> On 2016-04-05, Peter Hurley wrote: On 03/31/2016 01:41 AM, John Ogness wrote: > It has been observed that the TX-DMA can stall

Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-04-11 Thread Sebastian Andrzej Siewior
On 04/11/2016 07:53 PM, Peter Hurley wrote: > On 04/11/2016 01:18 AM, John Ogness wrote: >> On 2016-04-05, Peter Hurley wrote: >>> On 03/31/2016 01:41 AM, John Ogness wrote: It has been observed that the TX-DMA can stall >>> >>> Does this happen on any other OMAP part besides am335x? >>> I lo

Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-04-11 Thread Peter Hurley
On 04/11/2016 01:18 AM, John Ogness wrote: > On 2016-04-05, Peter Hurley wrote: >> On 03/31/2016 01:41 AM, John Ogness wrote: >>> It has been observed that the TX-DMA can stall >> >> Does this happen on any other OMAP part besides am335x? >> I looked back over the LKML history of this and didn't s

Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-04-11 Thread John Ogness
On 2016-04-05, Peter Hurley wrote: > On 03/31/2016 01:41 AM, John Ogness wrote: >> It has been observed that the TX-DMA can stall > > Does this happen on any other OMAP part besides am335x? > I looked back over the LKML history of this and didn't see > any other design implicated in this problem.

Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-04-04 Thread Peter Hurley
On 03/31/2016 01:41 AM, John Ogness wrote: > From: Sebastian Andrzej Siewior > > It has been observed that the TX-DMA can stall Does this happen on any other OMAP part besides am335x? I looked back over the LKML history of this and didn't see any other design implicated in this problem. > if te

Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-03-31 Thread One Thousand Gnomes
> + * TCSANOW requests the change to occur immediately, however > + * if we have a TX-DMA operation in progress then it has been > + * observed that it might stall and never complete. Therefore > + * we wait until DMA completes to prevent this han

Re: [PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-03-31 Thread John Ogness
On 2016-03-31, John Ogness wrote: > diff --git a/drivers/tty/serial/8250/8250_omap.c > b/drivers/tty/serial/8250/8250_omap.c > index 6f76051..9459b4d 100644 > --- a/drivers/tty/serial/8250/8250_omap.c > +++ b/drivers/tty/serial/8250/8250_omap.c > @@ -460,6 +451,24 @@ static void omap_8250_set_ter

[PATCH] tty: serial: 8250_omap: do not defer termios changes

2016-03-31 Thread John Ogness
From: Sebastian Andrzej Siewior It has been observed that the TX-DMA can stall if termios changes occur while a TX-DMA operation is in progress. Previously this was handled by allowing set_termios to return immediately and deferring the change until the operation is completed. Now set_termios wil