Re: [PATCH] tty: n_gsm: check error while registering tty devices

2021-04-10 Thread Greg KH
On Wed, Apr 07, 2021 at 04:21:30PM +0800, Hillf Danton wrote: > On Wed, 7 Apr 2021 07:37:53 Jiri Slaby wrote: > > > >Yes, the fix makes sense. > > Thanks for taking a look. > > >But could you elaborate in the commit log when this happens? > >I only wonder how real this is. I assume you inject fau

Re: [PATCH] tty: n_gsm: check error while registering tty devices

2021-04-08 Thread Hao Sun
> Can you share the info you know about the syzbot report? Sorry for the late reply, I don't know the REPORT information of syzbot because I haven't deployed it. The attached reproduction program was generated by syz-repro. As you can see from the repro.cprog, the bug occurred in the case of fault

Re: [PATCH] tty: n_gsm: check error while registering tty devices

2021-04-06 Thread Jiri Slaby
On 07. 04. 21, 4:16, Hillf Danton wrote: Add the error path for registering tty devices and roll back in case of error in bid to avoid the UAF like the below one reported. [ cut here ] refcount_t: underflow; use-after-free. WARNING: CPU: 1 PID: 8923 at lib/refcount.