Re: [PATCH] tty/sysrq: fix sparse warnings

2015-02-04 Thread Lad, Prabhakar
On Wed, Feb 4, 2015 at 6:27 PM, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch fixes following sparse warnings: > sysrq.c:58:16: warning: symbol 'platform_sysrq_reset_seq' was not declared. > Should it be static? > sysrq.c:59:5: warning: symbol 'sysrq_reset_downtime_ms' was not dec

Re: [PATCH] tty/sysrq: fix sparse warnings

2015-02-04 Thread Lad, Prabhakar
Hi Greg, On Wed, Feb 4, 2015 at 6:32 PM, Greg Kroah-Hartman wrote: > On Wed, Feb 04, 2015 at 06:27:31PM +, Lad Prabhakar wrote: >> From: "Lad, Prabhakar" > > Why put your name in a different order than is normally used? Please > just switch it around, tools don't like ',' all that much. > I

Re: [PATCH] tty/sysrq: fix sparse warnings

2015-02-04 Thread Greg Kroah-Hartman
On Wed, Feb 04, 2015 at 06:27:31PM +, Lad Prabhakar wrote: > From: "Lad, Prabhakar" Why put your name in a different order than is normally used? Please just switch it around, tools don't like ',' all that much. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe

[PATCH] tty/sysrq: fix sparse warnings

2015-02-04 Thread Lad Prabhakar
From: "Lad, Prabhakar" this patch fixes following sparse warnings: sysrq.c:58:16: warning: symbol 'platform_sysrq_reset_seq' was not declared. Should it be static? sysrq.c:59:5: warning: symbol 'sysrq_reset_downtime_ms' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar ---