Re: [PATCH] tty/nozomi: refactor macros and functions

2018-03-23 Thread Joey Pabalinas
On Fri, Mar 23, 2018 at 04:27:37PM +0100, Greg Kroah-Hartman wrote: > That's a lot of different things to do all in a single patch. > > Please break this up into a patch series, doing only one logical "thing" > per patch. Sorry about that, I'll spin up a patchset now. -- Cheers, Joey Pabalinas

Re: [PATCH] tty/nozomi: refactor macros and functions

2018-03-23 Thread Greg Kroah-Hartman
On Tue, Mar 20, 2018 at 06:34:30PM -1000, Joey Pabalinas wrote: > Cleanup a few messy sections of code by replacing constructs > like `len__ > TMP_BUF_MAX ? TMP_BUF_MAX : len__` with > `min_t(u32, len__, TMP_BUF_MAX)` and naming identifiers > more descriptively (where appropriate). > > A few secti

[PATCH] tty/nozomi: refactor macros and functions

2018-03-20 Thread Joey Pabalinas
Cleanup a few messy sections of code by replacing constructs like `len__ > TMP_BUF_MAX ? TMP_BUF_MAX : len__` with `min_t(u32, len__, TMP_BUF_MAX)` and naming identifiers more descriptively (where appropriate). A few sections were nested pretty deeply and have been replaced with shallower (but sem