Re: [PATCH] tty/n_hdlc: fix __might_sleep warning

2019-01-10 Thread Arnd Bergmann
On Thu, Jan 10, 2019 at 12:39 PM Tetsuo Handa wrote: > On 2019/01/02 5:28, Paul Fulghum wrote: > > Fix __might_sleep warning in tty/n_hdlc.c read due to copy_to_user call > > while current is TASK_INTERRUPTIBLE. > > This is a false positive since the code path does not depend on current > > stat

Re: [PATCH] tty/n_hdlc: fix __might_sleep warning

2019-01-10 Thread Tetsuo Handa
Hello, Greg. We attempted a cleanup but we failed. Thus, will you apply this patch for now? On 2019/01/02 5:28, Paul Fulghum wrote: > Fix __might_sleep warning in tty/n_hdlc.c read due to copy_to_user call while > current is TASK_INTERRUPTIBLE. > This is a false positive since the code path does

[PATCH] tty/n_hdlc: fix __might_sleep warning

2019-01-01 Thread Paul Fulghum
Fix __might_sleep warning in tty/n_hdlc.c read due to copy_to_user call while current is TASK_INTERRUPTIBLE. This is a false positive since the code path does not depend on current state remaining TASK_INTERRUPTIBLE. The loop breaks out and sets TASK_RUNNING after calling copy_to_user. This patc